Tolerate missing privileges on the HttpConfiguratiosn folder#217
Closed
AlexDanDuna wants to merge 3 commits into
Closed
Tolerate missing privileges on the HttpConfiguratiosn folder#217AlexDanDuna wants to merge 3 commits into
AlexDanDuna wants to merge 3 commits into
Conversation
Handle PermissionError without raising an exception to allow fallback to environment variables.
AlexDanDuna
requested review from
cameronwaterman,
rbell517 and
spanglerco
as code owners
Author
|
@rbell517 @spanglerco @cameronwaterman Please don't review yet. This is just preliminary, and I am yet to test locally and add automated tests. Converting to draft. |
Author
|
TODO: Add test |
Author
|
Dropping PR, no longer needed. It is enough to update the version used by SLS to >= 1.4.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle PermissionError without raising an exception to allow fallback to environment variables.
TODO: Check the above box with an 'x' indicating you've read and followed CONTRIBUTING.md.
What does this Pull Request accomplish?
TODO: Include high-level description of the changes in this pull request.
Why should this Pull Request be merged?
TODO: Justify why this contribution should be part of the project.
What testing has been done?
TODO: Detail what testing has been done to ensure this submission meets requirements.