Intercept the InterruptedError on Windows, and don't use shell.#244
Open
cyberfox wants to merge 1 commit into
Open
Intercept the InterruptedError on Windows, and don't use shell.#244cyberfox wants to merge 1 commit into
cyberfox wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you don't intercept the
InterruptedErrorit looks like this:It also does not successfully terminate the subprocesses because when it uses
'shell': TrueinPopen, it spawns a command console which does not appear to successfully pass on the termination message. Since this never ends the subprocesses, the parent process doesn't end, and everything hangs.If (when the
^Cfails to stop it) you kill the parenthonchoprocess using Task Manager, it ends, but it doesn't kill the subprocesses in that case.This is all on Windows 11. It is demonstratable with a simple
Procfilethat looks like:and a Python script that looks like:
Doing
honcho startfrom the Windows 11 command shell, and then hitting^Cdoesn't kill the subprocess (despite giving an ugly stack dump) nor does it exithonchountil the sleeps have completed on their own. With this patch, it gives a clean message that it's terminating, and it successfully terminates immediately.