This repository was archived by the owner on Nov 12, 2025. It is now read-only.
Allow use of arbitrary values as state and event tags#34
Open
mrnerdhair wants to merge 15 commits intonickuraltsev:masterfrom
Open
Allow use of arbitrary values as state and event tags#34mrnerdhair wants to merge 15 commits intonickuraltsev:masterfrom
mrnerdhair wants to merge 15 commits intonickuraltsev:masterfrom
Conversation
Author
|
(closing/reopening pr to trigger retest) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR: I switched the
Object.create(null)objects used to keep track of state and event configs withnew Map(), and made sure no assumptions are made regarding what objects get fed in. Strict equality semantics (===) are used when determining which state/event is being referred to in any calls.There are also some improvements regarding testing in here; I wrote a harness to allow running multiple instances of each unit test, one for each of 8 types of keys.