Open
Conversation
|
@nickw444 did you give any consideration to this PR? @XavierBerger do you have a public pip install package for a fork of this improvement? |
Author
|
@ssmithy I don't plan to publish a fork of this repo on PyPi. |
|
Appreciate the ping back - thank you 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Here is a quite massive pull request...
This pull request is containing additional test capabilities I used to test my
appdaemonapplications (ref my github for application and tests) :cancel_listen_state,listen_event,fire_event,immediatein callback,run_inI did add also the build environment I used which is VSCode Server inside HA web interface.
The code has been validated by
blakeandflake8as in this repository and also withpylintsince I use it in all my python dev.The code is fully tested with a coverage of 100%.
I hope you will find this pull request interesting. Anyway thanks for you job which allow me to have a coverage of 100% on my code.