Skip to content

Please consider the following formatting changes to #16570 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alibuild wants to merge 1 commit into from
Closed

Please consider the following formatting changes to #16570 #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions PWGJE/TableProducer/tableDiffWake.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2019-2020 CERN and copyright holders of ALICE O2.

Check failure on line 1 in PWGJE/TableProducer/tableDiffWake.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/workflow-file] 

Name of a workflow file must match the name of the main struct in it (without the PWG prefix). (Class implementation files should be in "Core" directories.)
// See https://alice-o2.web.cern.ch/copyright for details of the copyright holders.
// All rights not expressly granted are reserved.
//
Expand Down Expand Up @@ -127,9 +127,9 @@

HistogramRegistry histos{"histos", {}, OutputObjHandlingPolicy::AnalysisObject};
Configurable<int> nBinsPt{"nBinsPt", 100, "N bins in pT histo"};
Configurable<double> pT_thresh{"pT_thresh", 20.0, "pT threshold"};

Check failure on line 130 in PWGJE/TableProducer/tableDiffWake.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/configurable] 

Use lowerCamelCase for names of configurables and use the same name for the struct member as for the JSON string. (Declare the type and names on the same line.)
Configurable<float> cent_max{"cent_max", 10, "centrality"};

Check failure on line 131 in PWGJE/TableProducer/tableDiffWake.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/configurable] 

Use lowerCamelCase for names of configurables and use the same name for the struct member as for the JSON string. (Declare the type and names on the same line.)
Configurable<float> z_vert_cut{"z_vert_cut", 10.0, "z_vertex cut"};

Check failure on line 132 in PWGJE/TableProducer/tableDiffWake.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/configurable] 

Use lowerCamelCase for names of configurables and use the same name for the struct member as for the JSON string. (Declare the type and names on the same line.)

Produces<o2::aod::TableCol> testcol;
Produces<o2::aod::TableTrack> testtrack;
Expand Down Expand Up @@ -174,7 +174,7 @@
//------- Only events with track above some thresh ----------

bool eventHighpT = false;
for (auto& track : tracks) {

Check failure on line 177 in PWGJE/TableProducer/tableDiffWake.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.

if (!track.isGlobalTrack())
continue;
Expand All @@ -184,7 +184,7 @@
}
}
if (!eventHighpT)
return;
return;
//------------------------------------------------------------
// Translate values to less memory consuming values
Short_t Substitute_ep2 = (Short_t)(ep2 * 1000);
Expand All @@ -202,7 +202,7 @@
Substitute_ep2,
Substitute_ep3);

for (auto& track : tracks) {

Check failure on line 205 in PWGJE/TableProducer/tableDiffWake.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.

// Track cut
if (!track.isGlobalTrack())
Expand All @@ -220,7 +220,7 @@
Substitute_p |= (ULong64_t)1 << 20;
if (Particle_px < 0)
Particle_px = (-1) * Particle_px;
for (Int_t i_bit = 0; i_bit < 20; i_bit++) {

Check failure on line 223 in PWGJE/TableProducer/tableDiffWake.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
if ((Particle_px & ((Long64_t)1 << i_bit)))
Substitute_p |= (ULong64_t)1 << i_bit;
};
Expand All @@ -230,7 +230,7 @@
Substitute_p |= (ULong64_t)1 << 41;
if (Particle_py < 0)
Particle_py = (-1) * Particle_py;
for (Int_t i_bit = 21; i_bit < 41; i_bit++) {

Check failure on line 233 in PWGJE/TableProducer/tableDiffWake.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
if ((Particle_py & ((Long64_t)1 << (i_bit - 21))))
Substitute_p |= (ULong64_t)1 << i_bit;
};
Expand All @@ -240,7 +240,7 @@
Substitute_p |= (ULong64_t)1 << 62;
if (Particle_pz < 0)
Particle_pz = (-1) * Particle_pz;
for (Int_t i_bit = 42; i_bit < 62; i_bit++) {

Check failure on line 243 in PWGJE/TableProducer/tableDiffWake.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
if ((Particle_pz & ((Long64_t)1 << (i_bit - 42))))
Substitute_p |= (ULong64_t)1 << i_bit;
};
Expand All @@ -265,6 +265,6 @@

WorkflowSpec defineDataProcessing(ConfigContext const& cfgc)
{
return WorkflowSpec{
adaptAnalysisTask<tableDiffWake>(cfgc)};
return WorkflowSpec{
adaptAnalysisTask<tableDiffWake>(cfgc)};
}
Loading