Adds support for the Content-Encoding header#256
Adds support for the Content-Encoding header#256aminroosta wants to merge 6 commits intonicolasff:masterfrom
Conversation
|
Hi Amin, thanks for the PR! I've only given it a brief look so far but will spend some time on it today. In the meantime I did trigger the tests which run on a range of systems, they're all marked as failed simply because the same test failed in all environments; so it looks all red but it is really just about one test :-) From the output: To run this validation yourself, start Webdis with websockets enabled (set - "websockets": false,
+ "websockets": true,and in the You'll need to install cd tests
python -m venv .venv
source .venv/bin/activate
pip install -r requirements.txt
./basic.py
./ws-tests.py |
|
Hello @nicolasff, I appreciate you taking the time to review the PR. |
| suffix = ext + 1; | ||
| suffix_len = uri + uri_len - suffix; | ||
|
|
||
| for(ext = ext - 1; ext != uri && *ext != '/'; --ext) { |
Check notice
Code scanning / CodeQL
For loop variable changed in body Note
| suffix = ext + 1; | ||
| suffix_len = uri + uri_len - suffix; | ||
|
|
||
| for(ext = ext - 1; ext != uri && *ext != '/'; --ext) { |
Check notice
Code scanning / CodeQL
For loop variable changed in body Note
|
|
||
| for(ext = ext - 1; ext != uri && *ext != '/'; --ext) { | ||
| if(*ext == '.') { | ||
| ext++; |
Check notice
Code scanning / CodeQL
For loop variable changed in body Note
|
Will fix the unit tests later today. The python gzip implementation includes a timestamp. |
|
Done. |
Fixes #255