Skip to content

Random numbers generated needed fix #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zjasper122 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Random numbers generated needed fix #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions TwoLiterStack/src/main/TwoLiter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,20 @@ public TwoLiter(TwoLiter twoLiter) {
* @param twoLiterStack The Stack
* @param count The number of TwoLiter objects to add
*/
/*
EDIT:
Random.nextInt(int n) generates a random number in the range 0(inclusive) to n(exclusive).
We want to generate index for arrays flavors and UPCs randomly. So we need indexes from
0 to flavors.length-1 (both inclusive). So for upper bound we will have to add 1 to the upper bound
and the pass this to nextInt() method. So, correct call should be nextInt(flavors.length), then only it
will generate number from 0 to flavors.length-1 (both inclusive).
*/
public static void add(Stack<TwoLiter> twoLiterStack, int count ) {
// Random r = new Random(42);
Random r = new Random();
for (int i = 0; i < count; i++) {
twoLiterStack.add(new TwoLiter(UPCs[r.nextInt(UPCs.length - 1)],
flavors[r.nextInt(flavors.length - 1)],
twoLiterStack.add(new TwoLiter(UPCs[r.nextInt(UPCs.length )],
flavors[r.nextInt(flavors.length)],
1.00 + r.nextFloat()));
}
}
Expand Down
5 changes: 5 additions & 0 deletions bugFix.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Random.nextInt(int n) generates a random number in the range 0(inclusive) to n(exclusive).
We want to generate index for arrays flavors and UPCs randomly. So we need indexes from
0 to flavors.length-1 (both inclusive). So for upper bound we will have to add 1 to the upper bound
and the pass this to nextInt() method. So, correct call should be nextInt(flavors.length), then only it
will generate number from 0 to flavors.length-1 (both inclusive).