Add `leaveOpen` overloads for SepReaderOptions.From* via SepTextReaderDisposers by Copilot · Pull Request #530 · nietras/Sep

Copilot · 2026-04-27T18:37:04Z

SepReader IO extension methods always closed the underlying stream/reader on dispose, unlike the corresponding writer APIs. This made ownership hard to control when composing readers over externally managed streams.

API surface
- Add leaveOpen overloads for reader creation from:
  - Stream
  - Func<string, Stream>
  - TextReader
  - Func<string, TextReader>
- Mirror the existing writer-style ownership pattern in both sync and async reader extensions.
Implementation
- Use StreamReader(Stream, Encoding, Boolean, Int32, Boolean) for stream-backed reader overloads.
- Restore reader-side disposal plumbing so SepReader leave-open behavior matches writer closely for both sync and async disposal paths.
- Preserve existing default behavior (leaveOpen: false) for current callers.
Coverage
- Add focused tests covering disposal ownership for:
  - stream-backed readers
  - text-reader-backed readers
- Verify both leaveOpen: true and leaveOpen: false paths.

using var stream = GetCsvStream();
using var textReader = GetCsvTextReader();

// Existing behavior remains the default
using var reader1 = Sep.Reader().From(stream);
using var reader2 = Sep.Reader().From(textReader);

// New overloads keep the underlying source open
using var reader3 = Sep.Reader().From(stream, leaveOpen: true);
using var reader4 = Sep.Reader().From(textReader, leaveOpen: true);

> [!WARNING]
>
>

Agent-Logs-Url: https://github.com/nietras/Sep/sessions/e25d2005-3363-428e-86f5-1be461f8babc Co-authored-by: nietras <10798831+nietras@users.noreply.github.com>

nietras · 2026-04-27T19:02:37Z

this is bad, you shouldn't add a new set of types for disposal

nietras · 2026-04-27T19:06:50Z

also use StreamReader(Stream, Encoding, Boolean, Int32, Boolean) ctor

nietras · 2026-04-27T19:08:27Z

@copilot continue work as detailed by previous comments, don't add unnecessary stuff, simplify, keep succinct.

Agent-Logs-Url: https://github.com/nietras/Sep/sessions/19904039-5cc6-4f0a-a6cd-55ebc5c309c7 Co-authored-by: nietras <10798831+nietras@users.noreply.github.com>

Copilot · 2026-04-27T19:20:00Z

this is bad, you shouldn't add a new set of types for disposal

Updated in db7fc04. I removed the extra disposal types and restored the original SepReader disposal path.

also use StreamReader(Stream, Encoding, Boolean, Int32, Boolean) ctor

Updated in db7fc04. The stream-based reader overloads now use the StreamReader(..., leaveOpen) constructor directly.

@copilot continue work as detailed by previous comments, don't add unnecessary stuff, simplify, keep succinct.

Addressed in db7fc04. The change is simplified and limited to the native stream-based leaveOpen path.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

www.myget.org
- Triggering command: /usr/bin/dotnet dotnet test /home/REDACTED/work/Sep/Sep/src/Sep.Test/Sep.Test.csproj --nologo -c Debug --no-restore --filter FullyQualifiedName~SepReaderTest_Extensions_From --results-directory /tmp/sep-test-results-2 --logger trx;LogFileName=sep-reader-stream-leaveopen.trx (dns block)
- Triggering command: /usr/bin/dotnet dotnet restore /home/REDACTED/work/Sep/Sep/src/Sep.Test/Sep.Test.csproj --nologo --ignore-failed-sources (dns block)
- Triggering command: /opt/hostedtoolcache/CodeQL/2.25.1/x64/codeql/csharp/tools/linux64/Semmle.Autobuild.CSharp /opt/hostedtoolcache/CodeQL/2.25.1/x64/codeql/csharp/tools/linux64/Semmle.Autobuild.CSharp (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

nietras · 2026-04-29T13:17:20Z

@copilot ok you we're right to include Reader equivalent to below, so revert to that and ensure leaveOpen for Reader matches Writer closely.

interface ISepTextWriterDisposer
{
void Dispose(TextWriter writer);
ValueTask DisposeAsync(TextWriter writer);
}

sealed class SepTextWriterDisposer : ISepTextWriterDisposer
{
SepTextWriterDisposer() { }
public static SepTextWriterDisposer Instance { get; } = new();
public void Dispose(TextWriter writer) => writer.Dispose();
public ValueTask DisposeAsync(TextWriter writer) => writer.DisposeAsync();
}

sealed class NoopSepTextWriterDisposer : ISepTextWriterDisposer
{
NoopSepTextWriterDisposer() { }
public static NoopSepTextWriterDisposer Instance { get; } = new();
public void Dispose(TextWriter writer) { }
public ValueTask DisposeAsync(TextWriter writer) => ValueTask.CompletedTask;
}

nietras · 2026-04-29T13:19:59Z

@copilot also see changes made in #123 for how to and what to call this pr

Agent-Logs-Url: https://github.com/nietras/Sep/sessions/f84c8c35-3a73-427d-87d8-8392b865b1ba Co-authored-by: nietras <10798831+nietras@users.noreply.github.com>

Copilot · 2026-04-29T13:40:05Z

@copilot ok you we're right to include Reader equivalent to below, so revert to that and ensure leaveOpen for Reader matches Writer closely.

interface ISepTextWriterDisposer
...

Updated in b9d8a63. I restored the reader-side disposer pattern, brought back the text-reader leave-open overloads/tests, and aligned async reader disposal with the same leave-open flow.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

www.myget.org
- Triggering command: /usr/bin/dotnet dotnet test /home/REDACTED/work/Sep/Sep/src/Sep.Test/Sep.Test.csproj --nologo -c Debug --no-restore --filter FullyQualifiedName~SepReaderTest_Extensions_From --results-directory /tmp/sep-test-results-pre --logger trx;LogFileName=sep-reader-prechange.trx (dns block)
- Triggering command: /usr/bin/dotnet dotnet restore /home/REDACTED/work/Sep/Sep/src/Sep.Test/Sep.Test.csproj --nologo --ignore-failed-sources (dns block)
- Triggering command: /usr/bin/dotnet dotnet test /home/REDACTED/work/Sep/Sep/src/Sep.Test/Sep.Test.csproj --nologo -c Debug --no-restore --filter FullyQualifiedName~SepReaderTest_Extensions_From --results-directory /tmp/sep-test-results-post --logger trx;LogFileName=sep-reader-postchange.trx (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Copilot · 2026-04-29T13:43:25Z

@copilot also see changes made in #123 for how to and what to call this pr

Reviewed #123. This should follow that naming/style as the reader counterpart, e.g. Add leaveOpen overloads for SepReaderOptions.From via dispose action to ctor; the implementation already matches that in b9d8a63.

nietras · 2026-05-03T12:32:05Z

@copilot review PR after I fixed issues.

codecov · 2026-05-03T12:36:33Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.58%. Comparing base (61cbfdb) to head (260c6c9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #530      +/-   ##
==========================================
- Coverage   99.64%   99.58%   -0.07%     
==========================================
  Files          56       57       +1     
  Lines        4794     4815      +21     
  Branches      538      540       +2     
==========================================
+ Hits         4777     4795      +18     
  Misses         14       14              
- Partials        3        6       +3

Flag	Coverage Δ
Debug	`99.27% <100.00%> (+<0.01%)`	⬆️
Release	`99.61% <100.00%> (-0.18%)`	⬇️
macos-latest	`93.93% <100.00%> (+0.02%)`	⬆️
ubuntu-24.04-arm	`93.93% <100.00%> (+0.02%)`	⬆️
ubuntu-latest	`92.64% <100.00%> (-0.10%)`	⬇️
windows-11-arm	`93.93% <100.00%> (+0.02%)`	⬆️
windows-latest	`92.64% <100.00%> (-0.10%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot · 2026-05-03T12:43:14Z

@copilot review PR after I fixed issues.

Reviewed current head e01cb76. I don’t see any remaining issues in the leave-open reader changes, and the focused LeaveOpen tests pass on net10.0.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

www.myget.org
- Triggering command: /tmp/dotnet-10.0.203/dotnet /tmp/dotnet-10.0.203/dotnet test /home/REDACTED/work/Sep/Sep/src/Sep.Test/Sep.Test.csproj --filter SepReaderTest_Extensions_FromStream_LeaveOpen|SepReaderTest_Extensions_FromTextReader_LeaveOpen --no-restore (dns block)
- Triggering command: /tmp/dotnet-10.0.203/dotnet /tmp/dotnet-10.0.203/dotnet restore /home/REDACTED/work/Sep/Sep/src/Sep.Test/Sep.Test.csproj (dns block)
- Triggering command: /tmp/dotnet-10.0.203/dotnet /tmp/dotnet-10.0.203/dotnet restore /home/REDACTED/work/Sep/Sep/src/Sep.Test/Sep.Test.csproj -p:RestoreIgnoreFailedSources=true (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

nietras · 2026-05-03T12:47:43Z

Fix #529

This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [Sep](https://github.com/nietras/Sep) | `0.13.0` → `0.14.1` | ![age](https://developer.mend.io/api/mc/badges/age/nuget/Sep/0.14.1?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/Sep/0.13.0/0.14.1?slim=true) | --- ### Release Notes <details> <summary>nietras/Sep (Sep)</summary> ### [`v0.14.1`](https://github.com/nietras/Sep/releases/tag/v0.14.1): 0.14.1 #### What's Changed - Improve SepReaderOptions.Unescape/.Trim comments by [@nietras](https://github.com/nietras) in [#542](nietras/Sep#542) - Improve SepReader/WriterExtensions.Strict() comments by [@nietras](https://github.com/nietras) in [#543](nietras/Sep#543) **Full Changelog**: <nietras/Sep@v0.14.0...v0.14.1> ### [`v0.14.0`](https://github.com/nietras/Sep/releases/tag/v0.14.0): 0.14.0 #### What's Changed - Add `leaveOpen` overloads for SepReaderOptions.From\* via SepTextReaderDisposers by [@Copilot](https://github.com/Copilot) in [#530](nietras/Sep#530) - Bump MSTest from 4.2.1 to 4.2.2 by [@dependabot](https://github.com/dependabot)\[bot] in [#533](nietras/Sep#533) - Bump github/codeql-action from 4.35.2 to 4.35.3 by [@dependabot](https://github.com/dependabot)\[bot] in [#532](nietras/Sep#532) - Bump step-security/harden-runner from 2.19.0 to 2.19.1 by [@dependabot](https://github.com/dependabot)\[bot] in [#531](nietras/Sep#531) - Confirm statuses:write is the correct minimum permission for super-linter (not checks:write) by [@Copilot](https://github.com/Copilot) in [#540](nietras/Sep#540) **Full Changelog**: <nietras/Sep@v0.13.0...v0.14.0> </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.ryujinx.app/projects/Ryubing/pulls/98

Initial plan

9bb2eec

Copilot AI assigned Copilot and nietras Apr 27, 2026

Copilot started work on behalf of nietras April 27, 2026 18:37 View session

Copilot AI linked an issue Apr 27, 2026 that may be closed by this pull request

No "LeaveOpen" flag on the SepReaderOptions, inconsistent with the SepWriterOptions. #529

Closed

Add leave-open reader overloads

bdf75e7

Agent-Logs-Url: https://github.com/nietras/Sep/sessions/e25d2005-3363-428e-86f5-1be461f8babc Co-authored-by: nietras <10798831+nietras@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Add LeaveOpen flag to SepReaderOptions for consistency with SepWriterOptions~~ Add leave-open reader overloads for stream and text reader entry points Apr 27, 2026

Copilot finished work on behalf of nietras April 27, 2026 18:54

Copilot AI requested a review from nietras April 27, 2026 18:54

Copilot started work on behalf of nietras April 27, 2026 19:08 View session

Copilot AI and others added 2 commits April 27, 2026 19:15

Simplify reader leave-open support

25aa8a9

Agent-Logs-Url: https://github.com/nietras/Sep/sessions/19904039-5cc6-4f0a-a6cd-55ebc5c309c7 Co-authored-by: nietras <10798831+nietras@users.noreply.github.com>

Avoid double-disposing readers

db7fc04

Agent-Logs-Url: https://github.com/nietras/Sep/sessions/19904039-5cc6-4f0a-a6cd-55ebc5c309c7 Co-authored-by: nietras <10798831+nietras@users.noreply.github.com>

Copilot AI changed the title ~~Add leave-open reader overloads for stream and text reader entry points~~ Add leave-open reader overloads for stream entry points Apr 27, 2026

Copilot finished work on behalf of nietras April 27, 2026 19:21

Copilot started work on behalf of nietras April 29, 2026 13:17 View session

Copilot AI and others added 2 commits April 29, 2026 13:32

Restore reader leave-open parity

8aa5595

Agent-Logs-Url: https://github.com/nietras/Sep/sessions/f84c8c35-3a73-427d-87d8-8392b865b1ba Co-authored-by: nietras <10798831+nietras@users.noreply.github.com>

Align reader async disposal

b9d8a63

Agent-Logs-Url: https://github.com/nietras/Sep/sessions/f84c8c35-3a73-427d-87d8-8392b865b1ba Co-authored-by: nietras <10798831+nietras@users.noreply.github.com>

Copilot AI changed the title ~~Add leave-open reader overloads for stream entry points~~ Add leave-open reader overloads for stream and text reader entry points Apr 29, 2026

Copilot finished work on behalf of nietras April 29, 2026 13:41

Copilot started work on behalf of nietras April 29, 2026 13:42 View session

Copilot finished work on behalf of nietras April 29, 2026 13:45

simplify

5b70509

nietras added 4 commits May 3, 2026 14:11

readd base dispose call

710b376

cleanup streamreader creation

378a27a

simplify dispose

11ff740

cleanup sepreaderstate

e01cb76

nietras changed the title ~~Add leave-open reader overloads for stream and text reader entry points~~ Add leaveOpen overloads for SepReaderOptions.From* via SepTextReaderDisposers May 3, 2026

nietras marked this pull request as ready for review May 3, 2026 12:29

Copilot started work on behalf of nietras May 3, 2026 12:32 View session

nietras added 2 commits May 3, 2026 14:37

fix leaveOpen: false if underlying StreamReader has leaveOpen for stream

2b39126

disable benchmarkdotnet myget feed

260c6c9

nietras approved these changes May 3, 2026

View reviewed changes

Copilot AI requested a review from nietras May 3, 2026 12:43

Copilot finished work on behalf of nietras May 3, 2026 12:43

nietras merged commit 650d02e into main May 3, 2026
39 checks passed

nietras deleted the copilot/add-leaveopen-flag-sepreadoptions branch May 3, 2026 12:50

Conversation

Copilot AI commented Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nietras commented Apr 27, 2026

Uh oh!

nietras commented Apr 27, 2026

Uh oh!

nietras commented Apr 27, 2026

Uh oh!

Copilot AI commented Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

nietras commented Apr 29, 2026

Uh oh!

nietras commented Apr 29, 2026

Uh oh!

Copilot AI commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Copilot AI commented Apr 29, 2026

Uh oh!

nietras commented May 3, 2026

Uh oh!

codecov Bot commented May 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI commented May 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

nietras commented May 3, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Apr 27, 2026 •

edited

Loading

Copilot AI commented Apr 27, 2026 •

edited

Loading

Copilot AI commented Apr 29, 2026 •

edited

Loading

codecov Bot commented May 3, 2026 •

edited

Loading

Copilot AI commented May 3, 2026 •

edited

Loading