Skip to content

Improve SepReaderOptions.Unescape/.Trim comments#542

Merged
nietras merged 2 commits into
mainfrom
improve-unescape-xml-comment
May 5, 2026
Merged

Improve SepReaderOptions.Unescape/.Trim comments#542
nietras merged 2 commits into
mainfrom
improve-unescape-xml-comment

Conversation

@nietras
Copy link
Copy Markdown
Owner

@nietras nietras commented May 5, 2026

Fix #541

@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.64%. Comparing base (f864e31) to head (bf2cf82).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #542   +/-   ##
=======================================
  Coverage   99.64%   99.64%           
=======================================
  Files          57       57           
  Lines        4815     4815           
  Branches      540      540           
=======================================
  Hits         4798     4798           
  Misses         14       14           
  Partials        3        3           
Flag Coverage Δ
Debug 99.37% <ø> (ø)
Release 99.61% <ø> (ø)
macos-latest 93.93% <ø> (ø)
ubuntu-24.04-arm 93.93% <ø> (ø)
ubuntu-latest 92.75% <ø> (ø)
windows-11-arm 93.93% <ø> (ø)
windows-latest 92.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nietras nietras changed the title Improve SepReaderOptions.Unescape comment Improve SepReaderOptions.Unescape/.Trim comments May 5, 2026
@nietras nietras merged commit ffdfca5 into main May 5, 2026
39 checks passed
@nietras nietras deleted the improve-unescape-xml-comment branch May 5, 2026 12:41
github-actions Bot pushed a commit to Stella-sea/ryujinx-admin that referenced this pull request May 15, 2026
This PR contains the following updates:

| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [Sep](https://github.com/nietras/Sep) | `0.13.0` → `0.14.1` | ![age](https://developer.mend.io/api/mc/badges/age/nuget/Sep/0.14.1?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/nuget/Sep/0.13.0/0.14.1?slim=true) |

---

### Release Notes

<details>
<summary>nietras/Sep (Sep)</summary>

### [`v0.14.1`](https://github.com/nietras/Sep/releases/tag/v0.14.1): 0.14.1

#### What's Changed

- Improve SepReaderOptions.Unescape/.Trim comments by [@&#8203;nietras](https://github.com/nietras) in [#&#8203;542](nietras/Sep#542)
- Improve SepReader/WriterExtensions.Strict() comments by [@&#8203;nietras](https://github.com/nietras) in [#&#8203;543](nietras/Sep#543)

**Full Changelog**: <nietras/Sep@v0.14.0...v0.14.1>

### [`v0.14.0`](https://github.com/nietras/Sep/releases/tag/v0.14.0): 0.14.0

#### What's Changed

- Add `leaveOpen` overloads for SepReaderOptions.From\* via SepTextReaderDisposers by [@&#8203;Copilot](https://github.com/Copilot) in [#&#8203;530](nietras/Sep#530)
- Bump MSTest from 4.2.1 to 4.2.2 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;533](nietras/Sep#533)
- Bump github/codeql-action from 4.35.2 to 4.35.3 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;532](nietras/Sep#532)
- Bump step-security/harden-runner from 2.19.0 to 2.19.1 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;531](nietras/Sep#531)
- Confirm statuses:write is the correct minimum permission for super-linter (not checks:write) by [@&#8203;Copilot](https://github.com/Copilot) in [#&#8203;540](nietras/Sep#540)

**Full Changelog**: <nietras/Sep@v0.13.0...v0.14.0>

</details>

---

### Configuration

📅 **Schedule**: (UTC)

- Branch creation
  - At any time (no schedule defined)
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xNzguMCIsInVwZGF0ZWRJblZlciI6IjQzLjE3OC4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbXX0=-->

Reviewed-on: https://git.ryujinx.app/projects/Ryubing/pulls/98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unclear XML doc regarding .Span with Unescape = true

1 participant