Skip to content

[Feat] rtl support#18

Open
ali-garajian wants to merge 1 commit into
niikeec:mainfrom
ali-garajian:main
Open

[Feat] rtl support#18
ali-garajian wants to merge 1 commit into
niikeec:mainfrom
ali-garajian:main

Conversation

@ali-garajian

Copy link
Copy Markdown

closes #17

Apparently @tanstack/virtual doesn't work well with rtl layout in scenarios where horizontal overflow occurs, as mentioned here.

In order to fix the issue, one has to provide a proper value for overscan, which is not ideal.

However this PR works well in case there's no horizontal overflow, or as said if a proper overscan value is set.

@changeset-bot

changeset-bot Bot commented Apr 13, 2024

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 4a963e9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel

vercel Bot commented Apr 13, 2024

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
virtual-grid-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 13, 2024 7:43am
virtual-grid-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 13, 2024 7:43am

@niikeec

niikeec commented Apr 15, 2024

Copy link
Copy Markdown
Owner

I would prefer if the @tanstack/virtual issue gets solved first, as this would cause issues whenever horizontal scroll is present. I can look into their issue in my free time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

direction support

2 participants