Skip to content

fix: Explicitly mark parameters as nullable#42

Open
dimitri-guitton wants to merge 11 commits into
nikolaposa:masterfrom
dimitri-guitton:master
Open

fix: Explicitly mark parameters as nullable#42
dimitri-guitton wants to merge 11 commits into
nikolaposa:masterfrom
dimitri-guitton:master

Conversation

@dimitri-guitton
Copy link
Copy Markdown

This pull request addresses the deprecation warning related to implicitly marking parameters as nullable.

Comment thread src/Version.php Outdated
Comment thread src/Version.php Outdated
Comment thread tests/TestAsset/VersionIsIdentical.php Outdated
Comment thread tests/TestAsset/VersionIsIdentical.php Outdated
Comment thread tests/TestAsset/VersionIsIdentical.php Outdated
Comment thread tests/TestAsset/VersionIsIdentical.php Outdated
@nikolaposa nikolaposa self-assigned this Jan 27, 2025
@nikolaposa
Copy link
Copy Markdown
Owner

nikolaposa commented Jan 27, 2025

@d-loki Something is very off with code style in your fork. Check out the differences between:

https://github.com/nikolaposa/version/blob/master/src/Version.php

and

https://github.com/nikolaposa/version/blob/bf7c73d71a5aafcad2d3c4801bfae50cc4103a91/src/Version.php

where does that extra tab before every line comes from in your Version.php?

Screenshot 4

…and checkGenericClassInNonGenericObjectType

Replace with :
ignoreErrors:
            - identifier: missingType.generics
            - identifier: missingType.iterableValue
@dimitri-guitton
Copy link
Copy Markdown
Author

@nikolaposa I’ll check and fix the issue.
It's a configuration in my IDE. I'll start from your files and only make the necessary changes without letting my IDE update the code.

@dimitri-guitton
Copy link
Copy Markdown
Author

@nikolaposa I think it should be much better now.
Sorry for these issues, I didn’t notice that my IDE had updated the files during the commit.

@nikolaposa
Copy link
Copy Markdown
Owner

@dimitri-guitton
Copy link
Copy Markdown
Author

@d-loki Please fix these as well: https://github.com/nikolaposa/version/actions/runs/12990595086/job/36226775577?pr=42

It's fixed.

@VincentLanglet
Copy link
Copy Markdown
Contributor

Solved by #43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants