feat: add AGENTS.md and docs site pages#153
feat: add AGENTS.md and docs site pages#153blackandredbot wants to merge 14 commits intonikopueringer:mainfrom
Conversation
- Create AGENTS.md with all 12 sections following the AGENTS.md open format - Add docs site pages (architecture, contributing, usage, installation, etc.) - Add docs index link back to GitHub repo (mirrors upstream README change) - Add star-their-repo callout for GVM/VideoMaMa in docs/usage.md - Add test_agents_md.py with 18 unit tests and 5 Hypothesis PBT tests - Add test_docs_structure.py for docs site structure validation - docs/LLM_HANDOVER.md remains unmodified
- Move hypothesis imports to top of file (E402) in test_agents_md.py - Rename ambiguous variable 'l' to 'ln' (E741) in test_docs_structure.py - Apply ruff format to both test files
The cross-platform uv.lock drift was fixed in nikopueringer#133 (extras-based backends). Remove the now-stale uv.lock caveat from Platform-Specific Caveats, the prohibited-action entry, and the corresponding test assertions.
Add docs/ai-assisted-development.md covering context sources (AGENTS.md, LLM_HANDOVER.md), a tool-agnostic quick start, and per-tool configuration sections for Kiro, Claude Code, Cursor, GitHub Copilot, Windsurf, and Gemini CLI using pymdownx.tabbed content tabs. Update zensical.toml nav (Developer Guide section) and docs/index.md (Developer Guide card) with the new page entry. Add structural and property-based tests to tests/test_docs_structure.py: - test_ai_dev_page_exists, test_ai_dev_page_in_nav - TestNavEntryPreservation (Property 1) - TestIndexPageContentPreservation (Property 2) - test_ai_dev_page_has_required_content - test_index_page_links_to_ai_dev
|
Once GitHub Pages with Actions as the source is set up, this is what the experience will look like: https://blackandredbot.github.io/CorridorKey I noticed strange formatting on the index.md — so will make that fix real quick and make another commit b |
- Add attr_list and md_in_html extensions to zensical.toml (fixes grid cards rendering as plain text) - Remove stale uv.lock drift warnings from CONTRIBUTING.md and docs/contributing.md - Extract dev-setup and dev-commands snippets to reduce duplication - Add hero image to docs/index.md
- Add Antigravity (Google) tool config tab as first entry (original dev tool) - Enable pymdownx.emoji extension in zensical.toml to render icon shortcodes
Zensical requires explicit zensical.extensions.emoji namespace for pymdownx.emoji to inline SVG icons from bundled icon sets.
Captures lessons learned: snippet usage, emoji extension namespace, grid card extensions, video tags, and Zensical vs Material differences.
- Add custom 'star' admonition type with material/star icon - Update 'show these projects some love' callout to use star type - Add Kiro quick-start prompt that clones repo, reads AGENTS.md, and scaffolds steering files, hooks, and dev environment
The [project.theme.icon.admonition] config alone doesn't render custom admonition icons in Zensical. Added docs/stylesheets/extra.css with the star SVG mask and registered it via extra_css in zensical.toml.
|
Two specific concerns before this lands. ISSUE — The PR removes this block:
This warning doesn't appear anywhere in the new Fix: Move the warning into ISSUE — The section currently prohibits:
The three files that are fully off-limits for any modification aren't listed:
Also missing:
Fix: Expand Prohibited Actions to include all five of the above with a one-line rationale for each — the same format already used for the gamma 2.2 prohibition. |
AGENTS.md — Expand Prohibited Actions from 2 to 7 items. Add guardrails for the three core files (model_transformer, color_utils, inference_engine), the img_size=2048 training invariant, and sRGB/linear conversion order. docs/contributing.md — Add Lockfile Stability note under Apple Silicon explaining that cross-platform uv.lock drift was resolved in nikopueringer#133 via extras-based backends. Replaces the deleted 'do not commit uv.lock' warning with accurate current-state information.
|
Both addressed in AGENTS.md — Prohibited Actions: Expanded from 2 items to 7. The new entries (now items 1–5) cover:
The gamma 2.2 and gvm_core/VideoMaMa prohibitions remain as items 6–7. docs/contributing.md — uv.lock drift: Good catch on the deleted warning, but the underlying issue was fixed in #133 (extras-based backends made the lockfile platform-stable). Restoring the old "do not commit uv.lock" text would now be unnecessary. Instead, added a "Lockfile Stability" note under Apple Silicon explaining that the drift was resolved and how, so contributors have the context without the stale workaround. That said — if you're seeing something about the lockfile situation that #133 didn't fully address, I'd want to know. Is there a deeper risk here you think we should be covering? |
|
I’m extremely hesitant to implement docs and guides that are AI generated. If an LLM generated these from analyzing the code, then there’s really no reason to use these docs as opposed to letting LLMs continue to analyze the code. In addition, LLMs make abundant mistakes when planning image compositing, and I would bet that there are numerous issues introduced in these docs that can only be fixed by having a human expert with domain knowledge review them. That said, I am very appreciative of the effort to improve the project. I am going to close this PR for now. |
Closes #71
What does this change?
This PR adds two major pieces:
1.
AGENTS.md(the "README for AI agents")Creates
AGENTS.mdat the repo root following the AGENTS.md open format. It consolidates and restructures content fromdocs/LLM_HANDOVER.md,CONTRIBUTING.md,pyproject.toml, andREADME.mdinto 12 agent-optimized sections: project overview, architecture & dataflow, key file map, dev environment setup, build & test commands, code style, platform caveats, prohibited actions, PR workflow & GitHub templates, documentation accuracy, AI directives, and further reading.docs/LLM_HANDOVER.mdis not modified — it continues to serve the docs site. A property-based test enforces this.2. Docs site pages (Zensical/MkDocs Material)
Adds the full documentation site structure under
docs/:index.md,installation.md,usage.md,hardware-requirements.md,device-and-backend-selection.mdarchitecture.md,contributing.md_snippets/for reusable admonitions (model download, optional weights, Apple Silicon note, uv install)zensical.tomlsite configurationdocs/index.mddocs/usage.md(matching the recent README update)3. Tests
tests/test_agents_md.py— 18 unit tests + 5 Hypothesis property-based tests validating AGENTS.md content, structure, and LLM_HANDOVER.md preservationtests/test_docs_structure.py— docs site structure validation testsCaution
Before merging: Enable GitHub Pages
This PR includes a
docs.ymlworkflow that deploys the docs site to GitHub Pages via Zensical on pushes tomainthat touchdocs/**orzensical.toml. For the deployment to work, GitHub Pages must be enabled on the repo first:Without this, the
docs.ymlworkflow will run but the deployment step will fail with a permissions error. The rest of the PR (AGENTS.md, tests, docs content) is safe to merge regardless — only the automated deployment needs Pages enabled.GitHub docs: Configuring a publishing source for your GitHub Pages site
How was it tested?
uv run pytest tests/test_agents_md.py -v— all 23 tests pass (18 unit + 5 PBT)uv run pytest tests/test_docs_structure.py -v— docs structure tests passdocs/LLM_HANDOVER.mdis byte-identical tomain(Property 4 enforces this)Checklist
uv run pytestpassesuv run ruff checkpassesuv run ruff format --checkpasses