lon: don't abort on update fail#66
Open
es-sai-fi wants to merge 1 commit into
Open
Conversation
es-sai-fi
commented
May 17, 2026
| process::ExitCode, | ||
| }; | ||
|
|
||
| use anyhow::{Context, Result, bail}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should close #62.
I tested this on my end.
Even though the diff is fairly small, I'm still very much a newbie when it comes to Rust, so please review it carefully.
I tried writing an integration test for this, but I quickly found out why there aren't any for the
updatesubcommand already. I'm not sure whether this actually needs a test and, if so, how it should be implemented.I'm committing a test lock file for now in case anyone wants to test this themselves. I'll remove it later.