Skip to content

fixes #10 Add support for SSO/organization login#13

Open
seifrajhi wants to merge 1 commit intonilbuild:masterfrom
seifrajhi:master
Open

fixes #10 Add support for SSO/organization login#13
seifrajhi wants to merge 1 commit intonilbuild:masterfrom
seifrajhi:master

Conversation

@seifrajhi
Copy link
Copy Markdown

Description of change

We Would like to be able to get a cost summary of all of the accounts within our AWS Organization account using SSO login

Therefore, we want to use SSO login instead of configuring ~/.aws/credentials file with static credentials

Pull-Request Checklist

  • Code is up-to-date with the main branch
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions outlined in the conventional commit spec

@seifrajhi
Copy link
Copy Markdown
Author

Hello @kamranahmedse,

  • separate function is created loadSsoAwsCredentials
  • SSO retrieval is placed is last
  • Camel case is now used instead of underscores and creds is replaced by credentials

@seifrajhi
Copy link
Copy Markdown
Author

Below problem solved:

New output:

image

I am sorry for the inconvenience, I ran into many issues during merge

@seifrajhi
Copy link
Copy Markdown
Author

issue #12, is now closed because of PR issues

@seifrajhi
Copy link
Copy Markdown
Author

@kamranahmedse , can you please review the changes
thank you 🔢

@seifrajhi
Copy link
Copy Markdown
Author

Hi @kamranahmedse, do you think this PR needs more changes or it is good to go ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants