Add dial timeout#3
Conversation
nilslice
left a comment
There was a problem hiding this comment.
Good idea! To accept this PR, I would prefer that the timeout is passed in to Send, via a context.
Please let me know if you disagree. I'm imagining that you'd set up your Message, then your context.WithTimeout, and then call msg.Send(ctx), where your dialTimeout func gets the timeout from the context.
You could alternatively add a separate method SendContext(ctx) so there is no API change.
|
Hello @nilslice , sorry for late response. |
|
Hello @nilslice , I requested PR again, could you please check this? BTW, I'm not sure which is better using context or using variable(not a struct). Thank you 😄 |
|
Hi, I'm closing this after opening a new PR using your branch as a base. See #4 for more details. Thank you! |
Some service provider block personal ip address and some do not give any response.
In my case, naver.com act as waiting villain.