Let child process stderr inherit from parent in getNimbleDumpInfo#410
Open
ZoomRmc wants to merge 1 commit into
Open
Let child process stderr inherit from parent in getNimbleDumpInfo#410ZoomRmc wants to merge 1 commit into
ZoomRmc wants to merge 1 commit into
Conversation
getNimbleDumpInfo pipes the child process's stderr but never reads it. This silently discards any diagnostics nimble produces on stderr and needlessly consumes a file descriptor. In extreme cases it could also cause a pipe deadlock if the child writes enough stderr data to fill the pipe buffer before stdout closes. Fix: use an empty ProcessStreamHandle for stderr instead of piping. The child's stderr inherits from the parent process's stderr, which the editor or MCP host already captures and logs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getNimbleDumpInfo pipes the child process's stderr but never reads it. This silently discards any diagnostics nimble produces on stderr and needlessly consumes a file descriptor. In extreme cases it could also cause a pipe deadlock if the child writes enough stderr data to fill the pipe buffer before stdout closes.
Fix: use an empty ProcessStreamHandle for stderr instead of piping. The child's stderr inherits from the parent process's stderr, which the editor or MCP host already captures and logs.