add timeout guard for nimsuggest startup#411
Open
ZoomRmc wants to merge 1 commit into
Open
Conversation
createOrRestartNimsuggest blocks on waitFor(createNimsuggest(...)) which can hang indefinitely if nimsuggest fails to start or becomes unresponsive. This blocks tool calls and the MCP client eventually times out after 30 seconds, wasting time on every failure. Fix: wrap the createNimsuggest call in utils.withTimeout with a configurable NIMSUGGEST_STARTUP_TIMEOUT of 30 seconds. On timeout, the nimsuggest future is cancelled and the proc returns early with an error log instead of blocking the caller.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createOrRestartNimsuggestblocks onwaitFor(createNimsuggest(...))which can hang indefinitely if nimsuggest fails to start or becomes unresponsive. This blocks tool calls and the MCP client eventually times out after 30 seconds, wasting time on every failure.Fix: wrap the createNimsuggest call in utils.withTimeout with a configurable
NIMSUGGEST_STARTUP_TIMEOUTof 30 seconds. On timeout, the nimsuggest future is cancelled and the proc returns early with an error log instead of blocking the caller.