Update from Rf_findVar and Rf_findVarInFrame while maintaining backward compatibility for R < 4.5.0#1616
Open
Update from Rf_findVar and Rf_findVarInFrame while maintaining backward compatibility for R < 4.5.0#1616
Conversation
…rd compatibility if possible
Contributor
Author
|
Failing on Windows. @paciorek Does this look like any general testing issues you've seen recently? I'm guessing there was a failure compiling the package DLL, but the information is not very clear. My windows setup is stale so I'll have to update or find another option. |
Contributor
|
No the DLL load failure doesn't look familiar. But we've had lots of such squirrely failures in the prep steps for testing on various OS, that it's possible it's not related to the changes here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes R preprocessor checks for R version. For versions >= 4.5.0, uses of
Rf_findVarandRf_findVarInFrameare replaced withR_getVarandR_getVarExwith a little additional code. It is possible that testing will turn up some issues because evidently the older API calls were looser in some handling of some arguments, and I don't know for sure if we were relying on relevant cases in any way.