Open
Conversation
Support exact two-way interaction pairs between exogenous response blocks so additive models can capture coupled effects while preserving the existing trend and prediction APIs. Made-with: Cursor
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
Cover linear/spline and spline/spline pairings explicitly so the interactions PR verifies the supported basis combinations without changing the strict duplicate-pair validation. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
interaction_pairsfor exact two-way exogenous interaction terms built from each factor'slag=0response blockTest plan
uv run --project /Users/nimish/Projects/bennet/estimator/.worktrees/tsgam-exog-interactions --directory /Users/nimish/Projects/bennet/estimator/.worktrees/tsgam-exog-interactions pytest test/test_tsgam_exog_interactions.py test/test_tsgam_multi_frequency.py test/test_tsgam_trend.py -qMade with Cursor