Return sub_protocol on server accept#10
Open
nworbnhoj wants to merge 1 commit intoninjasource:masterfrom
Open
Conversation
It seem odd that this call to server_accept forces websocket_protocol to None. The change proposes a slightly less blunt approach of defaulting to WebSocketContext.sec_websocket_protocol_list[0] This probably should also include doco for the Server implmentation.
Owner
|
I like the idea of supporting sub protocols in the framer module but I don't think your implementation would work for all use cases. I would be better to pass in the chosen websocket sub protocol as follows: sec_websocket_key: &WebSocketKey,
sec_websocket_protocol: Option<&WebSocketSubProtocol>, |
ninjasource
requested changes
Jun 25, 2022
| .server_accept( | ||
| &websocket_context.sec_websocket_key, | ||
| None, | ||
| Some(WebSocketContext.sec_websocket_protocol_list[0]), |
Owner
There was a problem hiding this comment.
This is too fragile and I think we should rather take the chosen sec_websocket_protocol as a parameter to this fuinction
Owner
There was a problem hiding this comment.
PS, sorry it took so long to get back to you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seem odd that this call to server_accept forces websocket_protocol to None.
The change proposes a slightly less blunt approach of defaulting to WebSocketContext.sec_websocket_protocol_list[0]
This probably should also include doco for the Server implmentation.