Open
Conversation
yibeichan
reviewed
Oct 17, 2023
Collaborator
yibeichan
left a comment
There was a problem hiding this comment.
the content looks good to me. a few notes:
- do we want to set up a rough length limit for each notebook in the tutorial/how-to-guide/etc.
- I'm okay with using "we" when explaining things to the user; it feels like "we" are from the same group. we can use "you" when we want the user to try some exercises.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've only started the changes - for now I only worked on:
1_intro_pydra2_intro_functiontaskI've tried to think about the Diataxis suggestions, mostly about:
I've removed several sections thinking that they should be moved to:
1_intro_pydraIn addition I added several TODO-LINK to remember about the links from future Explanations (or Installation) sections. I also change "we" to "you" in most of the places.
Please let me know what you think! You can suggest changes in this PR, or if you prefer you can merge it and work on improvement starting from new master (as long as we don't have to resolve conflicts in the notebooks everything works :) )