External tag

[Sprexatura]

Adopt external-tag to serialized union values

[kanghyojun]

As I mentioned earlier, there are some style issues.

src/Nirum/Targets/Python.hs:850:1: too long line (107 chars)
src/Nirum/Targets/Python.hs:850:108: trailing (1) white space
src/Nirum/Targets/Python.hs:875:1: too long line (92 chars)
src/Nirum/Targets/Python.hs:876:57: trailing (1) white space
src/Nirum/Targets/Python.hs:884:15: trailing (4) white space

[kanghyojun]

@dahlia @Kroisse Could you all review the idea of this PR regardless of the failing of CI? We decided to support external tag by adding @external-tag annotation on record type. And maybe in the next minor version updates, we could support external tag as default.

[dahlia]

Annotations available to (virtually) every target should be documented in docs/annotation.md file as well (besides docs/serialization.md file).

[dahlia]

Changelogs should be the past tense. Also the following explanation does not have enough information:

external_tag via '@external-tag' annotation

[dahlia]

A trailing colon is missing.

[dahlia]

Should the @external-tag annotation be applied to tags, not union types? Does that mean some tags could be serialized as external-tag-style while some other tags are still serialized with "_tag" field at a time?

[Kroisse]

This field might be not necessary, because it already presented above.

[Kroisse]

And, I think @external-tag should be associated on the whole union, not on its tag. If not, it loses the advantage that can be decide which tag should be parsed at once.

[codecov]

Codecov Report

Merging #316 into master will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #316      +/-   ##
==========================================
+ Coverage   76.22%   76.26%   +0.04%     
==========================================
  Files          34       34              
  Lines        2902     2903       +1     
  Branches      194      196       +2     
==========================================
+ Hits         2212     2214       +2     
+ Misses        496      493       -3     
- Partials      194      196       +2

Impacted Files	Coverage Δ
src/Nirum/Targets/Python.hs	88.2% <100%> (+0.03%)	⬆️
src/Nirum/Constructs/Docs.hs	94.73% <0%> (ø)	⬆️
src/Nirum/Constructs/Annotation/Internal.hs	77.27% <0%> (ø)	⬆️
src/Nirum/Constructs/Identifier.hs	98.14% <0%> (+1.85%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c405f6...21f7c99. Read the comment docs.