Number of Events Retained as Configurable Value#44
Open
brott8 wants to merge 3 commits intoniruse:mainfrom
Open
Number of Events Retained as Configurable Value#44brott8 wants to merge 3 commits intoniruse:mainfrom
brott8 wants to merge 3 commits intoniruse:mainfrom
Conversation
- Allow changes to configuration workflow
Author
|
Note that I also tried to allow the integration to be reconfigured after initial setup, though I currently get a message saying:
Not sure why, but the pull request still gets the variables as successfully configurable during initial setup. |
Owner
|
Is this version works ?, or need some tests ? |
Author
|
This version works in my setup. Currently running with 10 events on my end, going for a couple of weeks now. |
niruse
approved these changes
Mar 28, 2026
niruse
approved these changes
Mar 28, 2026
Owner
|
I will merge this changes at evening today |
niruse
approved these changes
Apr 7, 2026
niruse
approved these changes
Apr 7, 2026
niruse
approved these changes
Apr 7, 2026
niruse
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Made it so that the
download_images,alerts_count, andhours_backvariables are configurable during integration setup. Currently,alerts_countis hard-coded to 5.