App a11y assert api by nishath-bs · Pull Request #2 · nishath-bs/webdriverio

nishath-bs · 2024-12-19T12:58:14Z

Proposed changes

Types of changes

Polish (an improvement for an existing feature)
Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation update (improvements to the project's docs)
Specification changes (updates to WebDriver command specifications)
Internal updates (everything related to internal scripts, governance documentation and CI files)

Checklist

I have read the CONTRIBUTING doc
I have added tests that prove my fix is effective or that my feature works
I have added the necessary documentation (if appropriate)
I have added proper type definitions for new commands (if appropriate)

Backport Request

//: # (The current main branch is the development branch for WebdriverIO v9. If your change should be released to the current major version of WebdriverIO (v8), please raise another PR with the same changes against the v8 branch.)

This change is solely for v9 and doesn't need to be back-ported
Back-ported PR at #XXXXX

Further comments

Reviewers: @webdriverio/project-committers

V8

packages/wdio-browserstack-service/src/util.ts

packages/wdio-browserstack-service/src/accessibility-handler.ts

packages/wdio-browserstack-service/src/util.ts

checking os version even if given in regex form

packages/wdio-browserstack-service/src/accessibility-handler.ts

packages/wdio-browserstack-service/src/util.ts

packages/wdio-browserstack-service/src/instrumentation/funnelInstrumentation.ts

packages/wdio-browserstack-service/src/util.ts

…es (webdriverio#14016) * bump the patch-deps-updates-v8 group across 1 directory with 18 updates --- updated-dependencies: - dependency-name: "@preact/preset-vite" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: patch-deps-updates-v8 - dependency-name: "@types/archiver" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: patch-deps-updates-v8 - dependency-name: "@vitejs/plugin-react" dependency-type: direct:development update-type: version-update:semver-patch dependency-group: patch-deps-updates-v8 - dependency-name: ejs-lint dependency-type: direct:development update-type: version-update:semver-patch dependency-group: patch-deps-updates-v8 - dependency-name: husky dependency-type: direct:development update-type: version-update:semver-patch dependency-group: patch-deps-updates-v8 - dependency-name: lerna dependency-type: direct:development update-type: version-update:semver-patch dependency-group: patch-deps-updates-v8 - dependency-name: unzipper dependency-type: direct:development update-type: version-update:semver-patch dependency-group: patch-deps-updates-v8 - dependency-name: csv-stringify dependency-type: direct:production update-type: version-update:semver-patch dependency-group: patch-deps-updates-v8 - dependency-name: "@vitest/spy" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: patch-deps-updates-v8 - dependency-name: mlly dependency-type: direct:production update-type: version-update:semver-patch dependency-group: patch-deps-updates-v8 - dependency-name: "@browserstack/ai-sdk-node" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: patch-deps-updates-v8 - dependency-name: "@percy/appium-app" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: patch-deps-updates-v8 - dependency-name: browserstack-local dependency-type: direct:production update-type: version-update:semver-patch dependency-group: patch-deps-updates-v8 - dependency-name: "@vitest/snapshot" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: patch-deps-updates-v8 - dependency-name: chokidar dependency-type: direct:production update-type: version-update:semver-patch dependency-group: patch-deps-updates-v8 - dependency-name: devtools-protocol dependency-type: direct:production update-type: version-update:semver-patch dependency-group: patch-deps-updates-v8 - dependency-name: object-inspect dependency-type: direct:production update-type: version-update:semver-patch dependency-group: patch-deps-updates-v8 - dependency-name: testingbot-tunnel-launcher dependency-type: direct:production update-type: version-update:semver-patch dependency-group: patch-deps-updates-v8 ... Signed-off-by: dependabot[bot] <support@github.com> * ignore deprecation errors --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Christian Bromann <git@bromann.dev>

sauravdas1997 · 2024-12-31T14:46:24Z

LGTM

add unit test for util file changes

Co-authored-by: Christian Bromann <git@bromann.dev>

* fixes in e2e mac tests * fixes * fixes * fixes * fixes * fixes in cucumber * fixes in cucumber tests * commenting out step def in then.js * revert changes * fixes in lit.test.js * fixes * fixes * fixes * fixes * fixes * fixes * fixes * fixes * fixes * revert changes * fixes

Co-authored-by: Christian Bromann <git@bromann.dev>

* fix: Handle paths for accessibility * fix: EOF * test: Add test cases * refactor: EOF --------- Co-authored-by: Christian Bromann <git@bromann.dev>

nishath-bs and others added 8 commits December 18, 2024 13:07

performScan changes for app-a11y

3bcbefc

v8.41.0

a33b7bf

catch failures onAfterCommand (webdriverio#13993)

46309d8

add neccessary variables for a11y in env

2d180b7

change polling timeout env

4cdf910

resolve error

81b1f77

remove unnecessary changes

6cf77f8

added polling api for app a11y results

785f71f

nishath-bs changed the base branch from main to v8 December 19, 2024 12:58

nishath-bs and others added 2 commits December 19, 2024 19:00

Merge pull request #3 from dbs-2001/v8

480f17e

V8

checking os version even if given in regex form

dc49aa0

kamal-kaur04 requested changes Dec 24, 2024

View reviewed changes

nishath-bs and others added 3 commits December 24, 2024 19:58

Merge pull request #4 from nishath-bs/fix-os-version-regex

ddc663b

checking os version even if given in regex form

review comment changes

84ba469

added instrumentation

915eb0b

kamal-kaur04 requested changes Dec 30, 2024

View reviewed changes

packages/wdio-browserstack-service/src/util.ts Outdated Show resolved Hide resolved

packages/wdio-browserstack-service/src/util.ts Outdated Show resolved Hide resolved

packages/wdio-browserstack-service/src/util.ts Outdated Show resolved Hide resolved

kamal-kaur04 requested changes Dec 30, 2024

View reviewed changes

packages/wdio-browserstack-service/src/util.ts Outdated Show resolved Hide resolved

kamal-kaur04 requested changes Dec 30, 2024

View reviewed changes

packages/wdio-browserstack-service/src/instrumentation/funnelInstrumentation.ts Outdated Show resolved Hide resolved

nishath-bs added 2 commits December 30, 2024 15:19

changed prop name for instrumentation

201003a

log message changes

da8b32e

sauravdas1997 suggested changes Dec 30, 2024

View reviewed changes

nishath-bs and others added 5 commits December 30, 2024 20:15

review comment changes

776f512

removed isPageOpened

1417b83

linting fixes

7cbe45e

added math round off and moved logger inside scannerVersion check

b9510bd

kamal-kaur04 approved these changes Jan 2, 2025

View reviewed changes

add unit test for util file changes

d694c40

dbs-2001 and others added 25 commits January 3, 2025 15:23

add test cases for app automate flow in accessibility handler

6c76ed1

add performa11yscan function testing for isappautomate true

d118acb

fix test cases in accessibility handle

ee81e8a

fix test cases in util

9ccbe96

Trigger Build

b946c98

linting fixes

21e98ab

added axios dependency

d760703

test case fixed in getAppA11yResults

cc07ddb

Trigger Build

c718c3b

Merge pull request #5 from nishath-bs/unit-test-mocha-cucumber-changes

7972028

add unit test for util file changes

add new lines at last in test files

bb405d5

removed axios package

9210c70

Update packages/wdio-browserstack-service/src/util.ts

0105266

Co-authored-by: Christian Bromann <git@bromann.dev>

compile issue fix

7e180eb

removed try catch and pollApi changes to without promise

8015b47

changed unit test for got request module

ba14582

comment for got module usage

7f1ff67

remove commas

c21acfe

fix ut

58a0d25

remove format

9d04399

[WDIO8] fixed empty process.execArgv (webdriverio#14150)

b9eb478

Co-authored-by: Christian Bromann <git@bromann.dev>

fixes for percy in wdio-v8 (webdriverio#14147)

a687153

Co-authored-by: Christian Bromann <git@bromann.dev>

Fix writable paths (webdriverio#14052)

ec16ce2

* fix: Handle paths for accessibility * fix: EOF * test: Add test cases * refactor: EOF --------- Co-authored-by: Christian Bromann <git@bromann.dev>

Merge branch 'v8' into app_a11y_assert_api

2f6cd33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

App a11y assert api#2

App a11y assert api#2
nishath-bs wants to merge 46 commits intov8from
app_a11y_assert_api

nishath-bs commented Dec 19, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sauravdas1997 commented Dec 31, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Conversation

nishath-bs commented Dec 19, 2024

Proposed changes

Types of changes

Checklist

Backport Request

Further comments

Reviewers: @webdriverio/project-committers

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sauravdas1997 commented Dec 31, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants