Skip to content

Login Logic updated. #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
purvesh-d wants to merge 1 commit into
base: feature/login_screen
Choose a base branch
from
Open

Login Logic updated. #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .idea/.name
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions app/src/main/java/com/example/myapplication/ui/login/LoginViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ class LoginViewModel(private val loginRepository: LoginRepository) : ViewModel()

private val _loginForm = MutableLiveData<LoginFormState>()
val loginFormState: LiveData<LoginFormState> = _loginForm
var IsUserLoggedIn = false

private val _loginResult = MutableLiveData<LoginResult>()
val loginResult: LiveData<LoginResult> = _loginResult
Copy link
Copy Markdown

@github-actions github-actions bot Apr 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AIReviewRadar

Thank you for the patch. Here's my review:

  1. The variable IsUserLoggedIn should follow the naming convention of lower camel case and be renamed to isUserLoggedIn.
  2. Please ensure that this variable is used correctly throughout the codebase to avoid any potential issues with login logic.

Here's the updated diff with the suggested changes:

@@ -13,6 +13,7 @@ class LoginViewModel(private val loginRepository: LoginRepository) : ViewModel()
 
     private val _loginForm = MutableLiveData<LoginFormState>()
     val loginFormState: LiveData<LoginFormState> = _loginForm
-    var IsUserLoggedIn = false
+    var isUserLoggedIn = false
 
     private val _loginResult = MutableLiveData<LoginResult>()
     val loginResult: LiveData<LoginResult> = _loginResult

Please make the necessary changes and let me know if you have any questions or need further assistance.

Expand Down Expand Up @@ -42,9 +43,9 @@ class LoginViewModel(private val loginRepository: LoginRepository) : ViewModel()
// A placeholder username validation check
private fun isUserNameValid(username: String): Boolean {
return if (username.contains('@')) {
Patterns.EMAIL_ADDRESS.matcher(username).matches()
!Patterns.EMAIL_ADDRESS.matcher(username).matches()
} else {
username.isNotBlank()
username.isBlank()
}
}

Copy link
Copy Markdown

@github-actions github-actions bot Apr 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 AIReviewRadar

Thank you for the patch. Here's my review:

  1. In the modified isUserNameValid function, the return value has been inverted for the case where the username contains an '@' symbol. This seems like a logical error, as usernames containing '@' symbols are typically valid email addresses. Please confirm if this change is intended and necessary for the functionality of the app.

Here's the updated diff with the suggested changes:

@@ -42,9 +43,9 @@ class LoginViewModel(private val loginRepository: LoginRepository) : ViewModel()
     // A placeholder username validation check
     private fun isUserNameValid(username: String): Boolean {
         return if (username.contains('@')) {
-            !Patterns.EMAIL_ADDRESS.matcher(username).matches()
+            Patterns.EMAIL_ADDRESS.matcher(username).matches()
         } else {
-            username.isBlank()
+            username.isNotBlank()
         }
     }

Please make the necessary changes and let me know if you have any questions or need further assistance.

Expand Down