Tiered directory wiring refactor#8
Open
Bukhtawar wants to merge 5 commits intonishchay21:tiered-directory-wiringfrom
Open
Tiered directory wiring refactor#8Bukhtawar wants to merge 5 commits intonishchay21:tiered-directory-wiringfrom
Bukhtawar wants to merge 5 commits intonishchay21:tiered-directory-wiringfrom
Conversation
…ting Signed-off-by: nishchay21 <nishcha@amazon.com>
…ting Signed-off-by: nishchay21 <nishcha@amazon.com>
Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com>
Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com>
nishchay21
reviewed
Apr 28, 2026
| ShardPath shardPath, | ||
| DataFormatRegistry dataFormatRegistry, | ||
| IndexSettings indexSettings | ||
| boolean directDelegate |
Owner
There was a problem hiding this comment.
This is just used for logging already removed in new revision
| ); | ||
| } | ||
|
|
||
| TieredDirectory formatTiered = new TieredDirectory( |
Owner
There was a problem hiding this comment.
We need a directory implementation per format given by format the plane old tiered directory will not work here.
nishchay21
force-pushed
the
tiered-directory-wiring
branch
7 times, most recently
from
656459a to
74cc806
Compare
nishchay21
force-pushed
the
tiered-directory-wiring
branch
from
74cc806 to
5e08a33
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The change was to TieredDataFormatAwareStoreDirectoryFactory. Previously, step 3 called dataFormatRegistry.getTieredDirectories() which asked each DataFormatPlugin.getTieredDirectory() for a custom directory
Now step 3 iterates dataFormatRegistry.getFormatDescriptors(indexSettings) and creates a dedicated TieredDirectory per registered format. Each format (e.g., "parquet") gets its own TieredDirectory instance in the formatDirectories map, sharing the same SubdirectoryAwareDirectory, RemoteSegmentStoreDirectory, and FileCache, but with independent prefetch settings. TieredSubdirectoryAwareDirectory.resolveFormatDirectory() now actually routes format-prefixed files to their dedicated TieredDirectory.
Related Issues
Resolves # opensearch-project#21361
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.