add server framework detection and overrides for tanstack#3
Draft
HomelessDinosaur wants to merge 1 commit into
Draft
add server framework detection and overrides for tanstack#3HomelessDinosaur wants to merge 1 commit into
HomelessDinosaur wants to merge 1 commit into
Conversation
tjholm
reviewed
Jun 9, 2026
| // so railpack serves the build output as a static SPA. Nitro emits a server | ||
| // at .output/server/index.mjs (same as Nuxt). @tanstack/start is the old name. | ||
| if c.pkg.hasAnyDependency("@tanstack/react-start", "@tanstack/solid-start", "@tanstack/start") { | ||
| return serverFramework{Name: "TanStack Start", StartCmd: "node .output/server/index.mjs"}, true |
Member
There was a problem hiding this comment.
Should this use the detected runtime? If the railpack output uses a bun base image for the runtime as an example this will fail as node will not be available
HomelessDinosaur
force-pushed
the
NIT-1230
branch
from
9dac970 to
649f63e
Compare
Member
Author
|
When this PR gets merged this can be closed and have a different approach using the custom providers. railwayapp/railpack#588 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.