Skip to content

perf(rollup): skip URI-scheme ids before this.resolve() #4253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
danielroe wants to merge 1 commit into
base: v2
Choose a base branch
from
+12 −0
Draft

perf(rollup): skip URI-scheme ids before this.resolve() #4253

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/rollup/plugins/externals.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ import { readPackageJSON, writePackageJSON } from "pkg-types";
import type { Plugin } from "rollup";
import semver from "semver";

const URI_SCHEME_RE = /^[a-z0-9]{2,}:/;

export function externals(opts: NodeExternalsOptions): Plugin {
const trackedExternals = new Set<string>();

Expand Down Expand Up @@ -83,6 +85,16 @@ export function externals(opts: NodeExternalsOptions): Plugin {
return null;
}

if (URI_SCHEME_RE.test(originalId)) {
if (
originalId.startsWith("node:") &&
!isExplicitInline(originalId, importer)
) {
return { id: originalId, external: true };
}
return null;
}

// Normalize path (windows)
const id = normalize(originalId);

Expand Down
Loading