fix(vscode): pin @types/vscode to engines.vscode floor#415
Merged
Conversation
vsce publish rejects @types/vscode (^1.120.0, from the #406 dependabot bump) being newer than engines.vscode (^1.75.0), which broke the VS Code marketplace publish step of the v1.3.0 release. Pin @types/vscode back to ^1.75.0 to match the declared engine floor. tsc still compiles clean — the extension uses no API newer than 1.75. Refs #406.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v1.3.0 release goreleaser job succeeded (binaries + packages live), but the VS Code marketplace publish job failed:
Root cause: dependabot PR #406 (merged just before the release) bumped
@types/vscodeto ^1.120.0. vsce refuses to publish when the declared@types/vscodeis newer thanengines.vscode.Fix: pin
@types/vscodeback to^1.75.0(matching the engine floor) rather than raisingengines.vscode, which would drop support for VS Code 1.75–1.119.tsc -p ./compiles clean — the extension uses no API newer than 1.75.Extension 0.1.0 is still not on the marketplace; publishing it happens after this merges (manual
vsce publishor a follow-up tag).Refs #406.