test(cpu): wire AllSuiteA compact 6502 smoke ROM#420
Merged
Conversation
Add Frank Kingswood's ~1.5 KB AllSuiteA.bin as a fast opcode/addressing gate complementing the Klaus functional suite (issue #398, v1.5.0 CPU coverage): - cpu/allsuite_test.go under the `klaus` build tag, reusing the Klaus download/cache/sha helpers. SHA-pinned from the pmonta/FPGA-netlist-tools mirror; downloaded on demand + cached (GPL-era ROM, not vendored). CHIPPY_ALLSUITE_BIN overrides. - Loads + enters at $4000, runs against VariantNMOS. Both pass and fail end in `JMP *` at $45C0, so the loop detects the self-loop then reads the result byte: $0210 == $FF is pass, anything else is the failing test number. Converges in 613 instructions. - CI klaus job widened to `-run 'TestKlaus|TestAllSuiteA'` and renamed. - README + docs/context.md updated. Closes #398
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of the v1.5.0 CPU-coverage issues (#398, epic #402).
What
Adds Frank Kingswood's AllSuiteA (~1.5 KB) as a fast opcode/addressing smoke ROM alongside the Klaus functional suite.
cpu/allsuite_test.go, build-tagklaus, reuseshttpDownload/verifySHA256/sha256SumOffromklaus_test.go.4801c945…) from thepmonta/FPGA-netlist-toolsmirror; downloaded-on-demand + cached under the user cache dir (not vendored).CHIPPY_ALLSUITE_BINoverrides.$4000, runs againstVariantNMOS.How it detects pass/fail
Both pass and fail paths end in
theend: JMP *(self-loop at$45C0), so the PC self-loop alone is ambiguous — the run loop detects the self-loop then reads the result byte:$0210 == $FFis pass, anything else is the failing test number (reported in the failure message). Verified againstAllSuiteA.asm.Result
Passes locally in 613 instructions (<1 ms). CI's cpu-rom job now runs
-run 'TestKlaus|TestAllSuiteA'(renamed "klaus + allsuite cpu tests").Docs
README test section (adds AllSuiteA + the
CHIPPY_ALLSUITE_BINoverride, fixes the stale./internal/cpu/...path) anddocs/context.mdmerged-PR note.Closes #398