Skip to content

Add Goblin control primitive (docs + minimal runtime helper)#7

Open
louspringer wants to merge 3 commits into
mainfrom
goblin-control-primitive
Open

Add Goblin control primitive (docs + minimal runtime helper)#7
louspringer wants to merge 3 commits into
mainfrom
goblin-control-primitive

Conversation

@louspringer

Copy link
Copy Markdown
Contributor

Implements Issue #6 as an initial operational binding.

Includes:

  • docs/goblin-control-primitive.md (human + agent contract)
  • src/goblin/control.py (minimal executable hook)

Goal: move Goblin from concept → executable signal.

Next steps:

  • integrate into validation pipeline
  • emit GoblinEvent from real inconsistencies
  • connect to SHACL validation failures

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2c5cc2ea3d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/goblin/control.py Outdated
return {
"type": "GoblinEvent",
"severity": max(severity, 2),
"action": "block" if severity >= 3 else "gate"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Block irreversible actions on Goblin detection

The new runtime helper emits "action": "gate" for severity 2 (including the default detect_goblin(True) path), which conflicts with the contract added in docs/goblin-control-primitive.md (IF inconsistency_detected ... block irreversible actions). If downstream code relies on the action field to enforce safeguards, the default inconsistency case will not block irreversible operations, weakening the control primitive exactly when it should fail safe.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant