docs: Fix missing newline necessary in docs website#5190
Conversation
Signed-off-by: Miko <110693261+mikomikotaishi@users.noreply.github.com>
Signed-off-by: Miko <110693261+mikomikotaishi@users.noreply.github.com>
|
Thanks! |
By the way, what else would need to be done before this disclaimer could be removed? What would a full test need to consist of for the module to be no longer experimental? (I'm not in a rush for anything, but I would be interested in providing additional improvements so that it can be stabilised.) Additionally, is there a reason |
I think the best we could do is to provide some mechanism to execute the test suite against the module. Maybe this is possible with some preprocessor magic. Then we would see if all features actually work at least for some compilers. Happy to see PRs!
We have some examples where we use |
Many of the tests I see (the CMake building tests in particular) simply check whether a file compiles after including I'm not too sure what could be done with preprocessor manipulation, or how much more extensive this would be, but at the very least expanding the current test would provide some greater confidence that things work.
Ah, I see, thanks. Though, wouldn't it be clearer to just write |
|
Maybe the next step should not necessarily be extending the scope of the tests, but rather the scope of the compilers. It would be good to extend https://json.nlohmann.me/community/quality_assurance/ with a list of compilers for which we know the module work. |
make amalgamate.In my previous PR, #5137, I didn't add a newline at the beginning of the bullet-point lists, which caused the list of exported symbols on the documentation page to not render correctly. This PR adds the needed newlines so that the list renders correctly. This furthermore removes the mention of exporting symbols from
std, as this is not actually necessary to access these specialisations (and was removed in a previous PR, #5164).