fix: support zero-member types in NLOHMANN_DEFINE_TYPE_* macros#5195
Closed
ShahabAhmed01 wants to merge 1 commit into
Closed
fix: support zero-member types in NLOHMANN_DEFINE_TYPE_* macros#5195ShahabAhmed01 wants to merge 1 commit into
ShahabAhmed01 wants to merge 1 commit into
Conversation
🔴 Amalgamation check failed! 🔴The source code has not been amalgamated. @ShahabAhmed01 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NLOHMANN_DEFINE_TYPE_*with no member fields produced invalidto_json/from_jsonbodies (e.g.nlohmann_json_j[] = nlohmann_json_t.).This PR adds
NLOHMANN_JSON_PASTE0andNLOHMANN_JSON_DOUBLE_PASTE0so empty__VA_ARGS__expand to no-ops, matching the expected empty function bodies for zero members.Fixes #4041.
Test plan
unit-udt_macro.cpp.