Add tall building areas, fixes to building areas and main#128
Open
einoyrjanainen wants to merge 1 commit into
Open
Add tall building areas, fixes to building areas and main#128einoyrjanainen wants to merge 1 commit into
einoyrjanainen wants to merge 1 commit into
Conversation
JuhoErvasti
reviewed
Jun 17, 2026
Collaborator
There was a problem hiding this comment.
I'll leave a general comment; the code itself for the most part is OK, but IMO this does not need to be its own algorithm, since the only thing that's different is that some features are filtered out. I see these options:
a) we leave the filtering up to the downstream user(s)
b) we add the filter step to GeneralizeBuildingAreas
c) we add GeneralizeTallBuildingAreas but make it inherit GeneralizeBuildingAreas, which would let users control its parameters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a new
tall-building-areasalgorithm that filters buildings by height class before delegating to the existing building areas workflow.Also fixes
GeneralizeBuildingAreasso it does not requirebuilding_function_idunless filtering is actually enabled, which avoids the KeyError when running the tall-building workflow with datasets that do not have that column.Type of change
Bug fix
New feature
Other
Non-breaking change
Breaking change
Developer checklist