Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a significant refactor of the Wagtail-WordPress Connector's development environment setup and command-line tools. The changes include replacing the previous
rich_click-based CLI commands with aMakefilefor managing WordPress, Wagtail, and Django tasks, as well as restructuring and improving the anchor link inspection functionality. Below is a summary of the most important changes:Migration to
Makefilefor Command ManagementMakefileto replace the previous CLI commands. It includes commands for managing WordPress containers, running Wagtail/Django tasks, importing WordPress data, and handling Node.js frontend assets. This simplifies the development workflow by consolidating all commands into a single file.Removal of Old CLI Commands
commands/cli.pyfile, which previously defined CLI commands for managing WordPress, Wagtail, and Django environments. The functionality has been replaced by theMakefile.commands/anchor_links.pyandcommands/inspector.pyfiles, which provided CLI commands for inspecting WordPress API endpoints and anchor links. These functionalities have been restructured and moved to standalone scripts. [1] [2]Refactor of Anchor Link Inspection
commands/find_anchor_links.pyscript to replace the oldanchor_links.pyfunctionality. The script now usesargparsefor argument parsing and includes improved error handling, colored output withcolorama, and a more modular design.commands/helpers.pyfile to centralize shared constants (e.g.,BASE_ENDPOINT,ENDPOINTS) and helper functions (e.g.,display_colored_text,show_endpoints) for better maintainability and reusability.