change settle_seas_offset to work when settlement age is not 0#693
Merged
Rick-Methot-NOAA merged 1 commit intoJul 28, 2025
Conversation
iantaylor-NOAA
approved these changes
Jul 24, 2025
Contributor
iantaylor-NOAA
left a comment
iantaylor-NOAA
left a comment
There was a problem hiding this comment.
Looks good as far as I can see. Thanks for fixing this so quickly.
Collaborator
Author
|
Thanks. This has existed since day 1 of 3.30 |
Rick-Methot-NOAA
deleted the
691-bug-error-in-linkage-of-recdev-to-n-at-age-matrix-with-complex-settlement-timing
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concisely describe what has been changed/addressed in the pull request.
See the issue for description of error in timing of time offset between spawning and settlement for certain model configurations
@alexjensen-NOAA
@alexjensen-NOAA
What tests have been done?
close comparison of results as documented in the issue.
Where are the relevant files?
<-- - [x] No test files are required for this pull request. -->
What tests/review still need to be done?
Is there an input change for users to Stock Synthesis?
<-- - [x] No, there was no input change. -->
Additional information (optional).