Skip to content

[feat] Update indices table#274

Open
sbreitbart-NOAA wants to merge 2 commits into
mainfrom
revamp-tab-indices
Open

[feat] Update indices table#274
sbreitbart-NOAA wants to merge 2 commits into
mainfrom
revamp-tab-indices

Conversation

@sbreitbart-NOAA
Copy link
Copy Markdown
Collaborator

@sbreitbart-NOAA sbreitbart-NOAA commented Jun 2, 2026

As per #273

@Schiano-NOAA In my testing, I see that the estimates can get pretty large. I think it'd be useful to format large numbers with commas, like with the format function. I'm not sure where to put this though; if I try in line 76, it causes issues downstream. Thoughts?

@sbreitbart-NOAA sbreitbart-NOAA changed the title Update indices table [feat] Update indices table Jun 2, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 2, 2026

New version checklist

  • Package version in DESCRIPTION has been updated
  • Release notes have been drafted/published
  • Cheatsheet content has been updated (if applicable)
  • Cheatsheet version has been updated

@sbreitbart-NOAA sbreitbart-NOAA linked an issue Jun 2, 2026 that may be closed by this pull request
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 2, 2026

Code Metrics Report

Coverage Code to Test Ratio Test Execution Time
67.0% 1:0.1 5m24s

Code coverage of files in pull request scope (95.8%)

Files Coverage
R/table_indices.R 95.8%

Reported by octocov

@Schiano-NOAA
Copy link
Copy Markdown
Collaborator

As per #273

@Schiano-NOAA In my testing, I see that the estimates can get pretty large. I think it'd be useful to format large numbers with commas, like with the format function. I'm not sure where to put this though; if I try in line 76, it causes issues downstream. Thoughts?

I can't remember where it is, but there is a point in the workflow (I want to say during process_table) where I had to change values from numeric to character in order to keep the trailing zeros. I would suggest doing it right after that step since I think what you are implying, the commas are being placed on a character?

Comment thread R/table_indices.R Outdated
@sbreitbart-NOAA
Copy link
Copy Markdown
Collaborator Author

As per #273
@Schiano-NOAA In my testing, I see that the estimates can get pretty large. I think it'd be useful to format large numbers with commas, like with the format function. I'm not sure where to put this though; if I try in line 76, it causes issues downstream. Thoughts?

I can't remember where it is, but there is a point in the workflow (I want to say during process_table) where I had to change values from numeric to character in order to keep the trailing zeros. I would suggest doing it right after that step since I think what you are implying, the commas are being placed on a character?

Yes! Thanks- found it in process_table(). If that change looks good to you, I'll merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Revamp]: table_indices()

2 participants