You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@Schiano-NOAA In my testing, I see that the estimates can get pretty large. I think it'd be useful to format large numbers with commas, like with the format function. I'm not sure where to put this though; if I try in line 76, it causes issues downstream. Thoughts?
@Schiano-NOAA In my testing, I see that the estimates can get pretty large. I think it'd be useful to format large numbers with commas, like with the format function. I'm not sure where to put this though; if I try in line 76, it causes issues downstream. Thoughts?
I can't remember where it is, but there is a point in the workflow (I want to say during process_table) where I had to change values from numeric to character in order to keep the trailing zeros. I would suggest doing it right after that step since I think what you are implying, the commas are being placed on a character?
As per #273 @Schiano-NOAA In my testing, I see that the estimates can get pretty large. I think it'd be useful to format large numbers with commas, like with the format function. I'm not sure where to put this though; if I try in line 76, it causes issues downstream. Thoughts?
I can't remember where it is, but there is a point in the workflow (I want to say during process_table) where I had to change values from numeric to character in order to keep the trailing zeros. I would suggest doing it right after that step since I think what you are implying, the commas are being placed on a character?
Yes! Thanks- found it in process_table(). If that change looks good to you, I'll merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per #273
@Schiano-NOAA In my testing, I see that the estimates can get pretty large. I think it'd be useful to format large numbers with commas, like with the
formatfunction. I'm not sure where to put this though; if I try in line 76, it causes issues downstream. Thoughts?