fix(git): remove debug_graph_descendant_of_semantics test with noisy eprintln output#20
Merged
noahbclarkson merged 1 commit intomainfrom Apr 28, 2026
Merged
Conversation
…eprintln output The test was a development artifact used to understand graph_descendant_of semantics before implementing the is_merged_into_main fix. It has no assertions — only eprintln! debugging output — and is superseded by the four actual unit tests added in bd637e3. Removing it eliminates 50 lines of dead test code and 16 eprintln! statements that would print to test output.
noahbclarkson
force-pushed
the
fix/cleanup-debug-test
branch
from
f7ca6c8 to
37b6723
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove the test from .
This test was a development artifact added alongside the fix in . It contains no assertions — only 16 debug statements that print commit SHAs, parent info, and graph reachability results to stderr whenever the test runs.
The four actual unit tests added in cover all the real behavior:
Changes
Verification