fix(ci): pin toolchain to 1.94.1 instead of stable#26
Draft
noahbclarkson wants to merge 1 commit intomainfrom
Draft
fix(ci): pin toolchain to 1.94.1 instead of stable#26noahbclarkson wants to merge 1 commit intomainfrom
noahbclarkson wants to merge 1 commit intomainfrom
Conversation
dtolnay/rust-toolchain@stable causes fmt diffs when stable toolchain updates between CI runs. The repo already has rust-toolchain.toml pinning 1.94.1 — align CI to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI is currently using
dtolnay/rust-toolchain@stablewhich updated rustfmt between runs, causing fmt checks to fail on an otherwise-green commit (57a0865).This PR pins CI to
1.94.1to matchrust-toolchain.tomlalready in the repo.Changes:
.github/workflows/ci.yml:stable→1.94.1(1 occurrence).github/workflows/release.yml:stable→1.94.1(4 occurrences)No code changes — only CI infrastructure.