use URL constructor when appending the id to url#198
Merged
Conversation
noahgrant
force-pushed
the
use_URL_when_appending_id
branch
from
71ff5b2 to
6e0074d
Compare
noahgrant
force-pushed
the
use_URL_when_appending_id
branch
from
6e0074d to
c1053b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes (includes issue number if applicable):
Fixes the issue where a url couldn't have fixed query params attached to it because the model id would get appended at the end.
Description of Proposed Changes: