Skip to content

upgrade to vite-plus 0.2.0#826

Closed
fengmk2 wants to merge 2 commits into
masterfrom
migrate-vite-plus-0.2.0
Closed

upgrade to vite-plus 0.2.0#826
fengmk2 wants to merge 2 commits into
masterfrom
migrate-vite-plus-0.2.0

Conversation

@fengmk2

@fengmk2 fengmk2 commented Jun 17, 2026

Copy link
Copy Markdown
Member

No description provided.

@socket-security

socket-security Bot commented Jun 17, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedvitest@​4.1.9981007999100

View full report

@pkg-pr-new

pkg-pr-new Bot commented Jun 17, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/node-modules/urllib@826

commit: 4d3d957

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request configures a pnpm catalog in pnpm-workspace.yaml for managing vite, vite-plus, and vitest dependencies, updates package.json and pnpm-lock.yaml to use these catalog definitions, and adds VS Code settings to use the OXC formatter. Feedback on these changes suggests removing a redundant language-specific formatter override for [javascriptreact] in .vscode/settings.json and explicitly specifying version ^0.2.0 for vite and vite-plus in the workspace catalog to ensure the intended upgrade is correctly locked.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread pnpm-workspace.yaml
Comment on lines +18 to +20
vite: npm:@voidzero-dev/vite-plus-core@latest
vitest: 4.1.9
vite-plus: latest

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The PR title indicates an upgrade to vite-plus version 0.2.0. However, using latest for vite and vite-plus currently resolves to 0.1.24 in pnpm-lock.yaml. To ensure the upgrade to 0.2.0 is correctly applied and locked, please specify ^0.2.0 explicitly in the catalog and regenerate the lockfile.

  vite: npm:@voidzero-dev/vite-plus-core@^0.2.0
  vitest: 4.1.9
  vite-plus: ^0.2.0

Comment thread .vscode/settings.json
Comment on lines +21 to +24
"editor.defaultFormatter": "oxc.oxc-vscode",
"[javascriptreact]": {
"editor.defaultFormatter": "oxc.oxc-vscode"
},

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since editor.defaultFormatter is set globally to oxc.oxc-vscode on line 21, the language-specific override for [javascriptreact] is redundant and can be removed.

Suggested change
"editor.defaultFormatter": "oxc.oxc-vscode",
"[javascriptreact]": {
"editor.defaultFormatter": "oxc.oxc-vscode"
},
"editor.defaultFormatter": "oxc.oxc-vscode",

@codecov

codecov Bot commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.91%. Comparing base (e96fec9) to head (4d3d957).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #826   +/-   ##
=======================================
  Coverage   94.91%   94.91%           
=======================================
  Files          10       10           
  Lines         747      747           
  Branches      235      235           
=======================================
  Hits          709      709           
  Misses         35       35           
  Partials        3        3           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 80a3af3f-0b87-474e-9048-4d939ffe24d3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch migrate-vite-plus-0.2.0

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@fengmk2 fengmk2 closed this Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant