Fix _utf8len typo for byte 0xFF in buf2string#297
Open
deepview-autofix wants to merge 1 commit intonodeca:masterfrom
Open
Fix _utf8len typo for byte 0xFF in buf2string#297deepview-autofix wants to merge 1 commit intonodeca:masterfrom
deepview-autofix wants to merge 1 commit intonodeca:masterfrom
Conversation
_utf8len[254] = _utf8len[254] = 1 was a typo that assigned index 254 twice, leaving _utf8len[255] at its loop-computed value of 6. Byte 0xFF is invalid UTF-8 and should map to length 1. When buf2string encountered a 0xFF byte, it would treat it as a 6-byte sequence, consuming up to 5 subsequent bytes and producing incorrect output. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Co-Authored-By: DeepView Autofix <276251120+deepview-autofix@users.noreply.github.com> Co-Authored-By: Nikita Skovoroda <chalkerx@gmail.com> Signed-off-by: Nikita Skovoroda <chalkerx@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_utf8len[254] = _utf8len[254] = 1 was a typo that assigned index 254 twice, leaving _utf8len[255] at its loop-computed value of 6. Byte 0xFF is invalid UTF-8 and should map to length 1. When buf2string encountered a 0xFF byte, it would treat it as a 6-byte sequence, consuming up to 5 subsequent bytes and producing incorrect output.