feat: introduce addon-verify generator#174
Merged
araujogui merged 2 commits intonodejs:mainfrom Jan 13, 2025
Merged
Conversation
Member
|
Another nit but could you also add |
flakey5
approved these changes
Jan 10, 2025
Member
flakey5
left a comment
flakey5
left a comment
There was a problem hiding this comment.
Few nits but lgtm! Thank you!
Member
Author
Thanks, fixed the issues. |
araujogui
force-pushed
the
feat/addon-verify
branch
from
76cd679 to
4b2daec
Compare
ovflowd
reviewed
Jan 13, 2025
| * @param {string} sectionName Section name | ||
| * @returns {string} | ||
| */ | ||
| export function normalizeSectionName(sectionName) { |
ovflowd
reviewed
Jan 13, 2025
| return addons; | ||
| }, {}); | ||
|
|
||
| const files = await Promise.all( |
Member
There was a problem hiding this comment.
These should be broken down to separate functions on an utility file.
ovflowd
reviewed
Jan 13, 2025
| export const updateFilesForBuild = files => { | ||
| const updatedFiles = files.map(({ name, content }) => { | ||
| if (name === 'test.js') { | ||
| content = `'use strict'; |
Member
There was a problem hiding this comment.
Hmmm, I wonder if there is a better way of doing it!
ovflowd
reviewed
Jan 13, 2025
Member
ovflowd
left a comment
ovflowd
left a comment
There was a problem hiding this comment.
I left some comments. @araujogui could you make a follow-up PR?
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Create addon-verify generator
Validation
I compared the output of the old generator with this one, and they are identical.
Related Issues
Fixes #151
Check List