Skip to content

Change output directory to 'out/learn'#14

Merged
avivkeller merged 1 commit intomainfrom
avivkeller-patch-1
Apr 2, 2026
Merged

Change output directory to 'out/learn'#14
avivkeller merged 1 commit intomainfrom
avivkeller-patch-1

Conversation

@avivkeller
Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: Aviv Keller <me@aviv.sh>
Copilot AI review requested due to automatic review settings April 2, 2026 18:11
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nodejs-learn Building Building Preview Apr 2, 2026 6:11pm

Request Review

@avivkeller avivkeller merged commit 5908a6d into main Apr 2, 2026
5 of 6 checks passed
@avivkeller avivkeller deleted the avivkeller-patch-1 branch April 2, 2026 18:11
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the doc-kit build configuration to emit the generated static site under a nested output directory (out/learn), presumably to support hosting under a /learn base path.

Changes:

  • Change doc-kit global.output from out to out/learn.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

export default {
global: {
output: 'out',
output: 'out/learn',
Copy link

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the doc-kit output to out/learn makes the build output no longer match the configured deploy roots. In this repo, vercel.json still has outputDirectory: "out" and the GitHub Pages workflow uploads out/ as the site root, so the generated entrypoint will end up at out/learn/index.html and deployments are likely to serve an empty site / 404 at /. Align the deployment configuration with this new output path (e.g., update Vercel outputDirectory and Pages artifact path, or keep global.output as out and configure routing/base path another way).

Suggested change
output: 'out/learn',
output: 'out',

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants