Skip to content

feat: add legal text + fix analytics#18

Merged
avivkeller merged 8 commits intomainfrom
legal-legal-legal
Apr 2, 2026
Merged

feat: add legal text + fix analytics#18
avivkeller merged 8 commits intomainfrom
legal-legal-legal

Conversation

@avivkeller
Copy link
Copy Markdown
Member

@avivkeller avivkeller commented Apr 2, 2026

This PR adds legal information, and fixes the analytics URL

Copilot AI review requested due to automatic review settings April 2, 2026 19:33
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nodejs-learn Ready Ready Preview Apr 2, 2026 8:48pm

Request Review

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a custom footer for the doc layout to include required legal/trademark text and adds configuration changes intended to fix Vercel Analytics / Speed Insights behavior for the generated static site.

Changes:

  • Switch components/Layout to use a local components/Footer implementation instead of #theme/Footer.
  • Add a new components/Footer that renders social links plus required OpenJS/Node.js legal + policy links.
  • Configure <Analytics /> and <SpeedInsights /> with an explicit basePath.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
components/Layout/index.jsx Uses the new local footer and sets Analytics/SpeedInsights basePath.
components/Footer/index.jsx New footer implementation containing legal text, policy links, and social links.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@avivkeller avivkeller changed the title feat: add legal text + fix analytics feat: add legal text Apr 2, 2026
@avivkeller avivkeller changed the title feat: add legal text feat: add legal text + fix analytics Apr 2, 2026
Signed-off-by: Aviv Keller <me@aviv.sh>
@avivkeller avivkeller enabled auto-merge April 2, 2026 20:48
@avivkeller avivkeller added this pull request to the merge queue Apr 2, 2026
Merged via the queue into main with commit 110bde4 Apr 2, 2026
5 checks passed
@avivkeller avivkeller deleted the legal-legal-legal branch April 2, 2026 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants