Skip to content

fix: update event loop timers and nexttick page#23

Merged
avivkeller merged 1 commit intonodejs:mainfrom
slavamuravey:patch-2
Apr 5, 2026
Merged

fix: update event loop timers and nexttick page#23
avivkeller merged 1 commit intonodejs:mainfrom
slavamuravey:patch-2

Conversation

@slavamuravey
Copy link
Copy Markdown
Contributor

I investigated libuv uv_run function and libuv Design overview section and I propose to correct Node.js documentation related with event loop phases order.
It is a common misconception to think that the timer phase is the first one. Actually, it is the last one within event loop iteration.

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nodejs-learn Canceled Canceled Apr 4, 2026 1:28pm

Request Review

@slavamuravey
Copy link
Copy Markdown
Contributor Author

@avivkeller

@avivkeller
Copy link
Copy Markdown
Member

Why are you pinging me? This can't land as:

  1. It hasn't been 48 hours
  2. It doesn't follow our commit guidelines

@slavamuravey
Copy link
Copy Markdown
Contributor Author

slavamuravey commented Apr 4, 2026

  1. It doesn't follow our commit guidelines

@avivkeller Please, clarify. Need some changes in the PR?

@avivkeller
Copy link
Copy Markdown
Member

@slavamuravey
Copy link
Copy Markdown
Contributor Author

@avivkeller This PR is the same as previous merged PR nodejs/nodejs.org#8611.
What exactly wrong with the PR?

Signed-off-by: Viacheslav Muravyev <slavamuravey@mail.ru>
@slavamuravey slavamuravey changed the title Update event-loop-timers-and-nexttick.md fix: update event loop timers and nexttick page Apr 4, 2026
@avivkeller avivkeller merged commit 1e90e68 into nodejs:main Apr 5, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants