fix(docs): replace absolute URLs with relative links across pages#43
Merged
avivkeller merged 2 commits intonodejs:mainfrom Apr 5, 2026
Conversation
Internal links were using absolute paths (e.g. /asynchronous-work/...) which broke because the site is hosted under /learn/. Rather than hardcoding /learn/ as a prefix, convert all internal links to relative paths so they are portable and work regardless of the base URL. Affected pages: - asynchronous-work/discover-promises-in-nodejs - asynchronous-work/understanding-processnexttick - asynchronous-work/overview-of-blocking-vs-non-blocking - diagnostics/live-debugging/index - diagnostics/live-debugging/using-inspector - diagnostics/memory/index - diagnostics/poor-performance/index - diagnostics/poor-performance/using-linux-perf - getting-started/how-much-javascript-do-you-need-to-know-to-use-nodejs - typescript/transpile - typescript/publishing-a-ts-package
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
Thanks for the feedback! I've updated all internal links to use the |
avivkeller
approved these changes
Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #42
Internal links across multiple documentation pages were using absolute
paths (e.g.
/asynchronous-work/...) which broke on the live sitebecause the docs are served under
/learn/.Rather than hardcoding
/learn/as a prefix, this PR converts allinternal links to relative paths, which are portable and work
regardless of the base URL.
Affected Pages
asynchronous-work/discover-promises-in-nodejsasynchronous-work/understanding-processnexttickasynchronous-work/overview-of-blocking-vs-non-blockingdiagnostics/live-debugging/indexdiagnostics/live-debugging/using-inspectordiagnostics/memory/indexdiagnostics/poor-performance/indexdiagnostics/poor-performance/using-linux-perfgetting-started/how-much-javascript-do-you-need-to-know-to-use-nodejstypescript/transpiletypescript/publishing-a-ts-packageExample
Before:
After: