Add loader supporting mixed-format packages#8
Merged
JakobJingleheimer merged 3 commits intomainfrom Aug 31, 2022
Merged
Conversation
GeoffreyBooth
approved these changes
Aug 31, 2022
Co-authored-by: Geoffrey Booth <456802+GeoffreyBooth@users.noreply.github.com>
aduh95
reviewed
Aug 31, 2022
Comment on lines
+28
to
+33
| if (src.match(/exports[\.( ?=)]/)) { return true }; | ||
|
|
||
| if ( | ||
| src.match(/require\(/) | ||
| && !src.match(/createRequire\(/) | ||
| ) return true; |
There was a problem hiding this comment.
We should be using /regex/.test here, much faster than 'string'.match as it doesn't need to create an array.
Member
Author
There was a problem hiding this comment.
Ahh, good call. I'll send an update this evening
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This loader enables (with non-robust checks) loading both CJS and ESM from the same package where the package declares a single type.
This is a common scenario in older packages that distribute both CJS and ESM yet mark themselves as commonjs (either by omission of
"type"or by relying on the non-standard"module"field).Depends on nodejs/node#44396