[v16.x backport] test runner additions by MoLow · Pull Request #44873 · nodejs/node

MoLow · 2022-10-03T10:07:15Z

backports:

targos · 2022-10-03T10:14:57Z

If possible, we prefer to keep separated commits in backports, so we know from the git log what landed in the release line

PR-URL: nodejs#44241 Backport-PR-URL: nodejs#44873 Fixes: nodejs#44023 Fixes: nodejs#43675 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

PR-URL: nodejs#44450 Backport-PR-URL: nodejs#44873 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>

PR-URL: nodejs#44520 Backport-PR-URL: nodejs#44873 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

PR-URL: nodejs#44614 Backport-PR-URL: nodejs#44873 Fixes: nodejs#44611 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

PR-URL: nodejs#44620 Backport-PR-URL: nodejs#44873 Fixes: nodejs#44600 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

MoLow · 2022-10-03T10:16:26Z

@targos I am not sure what you meant - but you commented before I have committed. I just wanted to have a backport pr URL before cherry-picking the relevant commits.
is the PR ok now?

targos · 2022-10-03T10:18:21Z

@MoLow Looks like I was too fast indeed. This looks ok 👍🏻 (btw, you can add the Backport-PR-URL yourself, but that would be already done automatically when we land it with git-node land --backport)

PR-URL: nodejs#44241 Backport-PR-URL: nodejs#44873 Fixes: nodejs#44023 Fixes: nodejs#43675 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

PR-URL: nodejs#44450 Backport-PR-URL: nodejs#44873 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>

PR-URL: nodejs#44520 Backport-PR-URL: nodejs#44873 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

PR-URL: nodejs#44614 Backport-PR-URL: nodejs#44873 Fixes: nodejs#44611 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

PR-URL: nodejs#44620 Backport-PR-URL: nodejs#44873 Fixes: nodejs#44600 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

MoLow · 2022-10-03T12:07:36Z

v16 linter seems broken regardless of this PR

PR-URL: nodejs#44241 Backport-PR-URL: nodejs#44873 Fixes: nodejs#44023 Fixes: nodejs#43675 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

PR-URL: nodejs#44450 Backport-PR-URL: nodejs#44873 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>

PR-URL: nodejs#44520 Backport-PR-URL: nodejs#44873 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

PR-URL: nodejs#44614 Backport-PR-URL: nodejs#44873 Fixes: nodejs#44611 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

PR-URL: nodejs#44620 Backport-PR-URL: nodejs#44873 Fixes: nodejs#44600 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

targos · 2022-10-03T14:00:16Z

v16 linter seems broken regardless of this PR

@juanarbol it seems to be broken since the last push to v16.x-staging

PR-URL: nodejs#44520 Backport-PR-URL: nodejs#44873 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

PR-URL: nodejs#44620 Backport-PR-URL: nodejs#44873 Fixes: nodejs#44600 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

PR-URL: nodejs#44592 Backport-PR-URL: nodejs#44873 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

nodejs-github-bot · 2022-11-23T23:45:54Z

CI: https://ci.nodejs.org/job/node-test-pull-request/48143/

MoLow · 2022-11-24T00:22:46Z

@richardlau CI is running #44873 (comment)

nodejs-github-bot · 2022-11-24T13:23:49Z

CI: https://ci.nodejs.org/job/node-test-pull-request/48159/

nodejs-github-bot · 2022-11-27T22:02:08Z

CI: https://ci.nodejs.org/job/node-test-pull-request/48214/

This was confirmed flaky on those platforms: - Windows x64 - Windows on Arm - Linux - Freebsd Tests randomly fail because of bad order in messages expected, which seems related to threads scheduling at execution. PR-URL: nodejs#45049 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs-github-bot · 2022-11-30T21:04:08Z

CI: https://ci.nodejs.org/job/node-test-pull-request/48253/

nodejs-github-bot · 2022-12-01T05:56:04Z

CI: https://ci.nodejs.org/job/node-test-pull-request/48256/

MoLow · 2022-12-01T07:18:46Z

@richardlau can this be merged?

richardlau · 2022-12-07T14:45:16Z

Landed in 5a776d4...821d832.

This comment was marked as outdated.

Sign in to view

MoLow changed the base branch from main to v16.x-staging October 3, 2022 10:07

nodejs-github-bot added meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Oct 3, 2022

MoLow force-pushed the backport-v16-test-runner branch from b6d316e to f44fcd9 Compare October 3, 2022 10:15

MoLow marked this pull request as ready for review October 3, 2022 10:16

MoLow force-pushed the backport-v16-test-runner branch from f44fcd9 to d351059 Compare October 3, 2022 11:31

MoLow added the v16.x label Oct 3, 2022

MoLow added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Oct 3, 2022

MoLow force-pushed the backport-v16-test-runner branch from d351059 to 23ab7fe Compare October 3, 2022 13:08

MoLow added 3 commits November 24, 2022 00:46

test_runner: support using --inspect with --test

6e980bf

PR-URL: nodejs#44520 Backport-PR-URL: nodejs#44873 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

test: fix test-runner-inspect

3c4c0cd

PR-URL: nodejs#44620 Backport-PR-URL: nodejs#44873 Fixes: nodejs#44600 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

cluster: use inspector utils

36be71e

PR-URL: nodejs#44592 Backport-PR-URL: nodejs#44873 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

MoLow force-pushed the backport-v16-test-runner branch from ea19306 to 36be71e Compare November 23, 2022 22:46

MoLow mentioned this pull request Nov 24, 2022

[v16.x backport] backport multiple test runner features #45602

Closed

This comment was marked as resolved.

Sign in to view

This comment was marked as outdated.

Sign in to view

This was referenced Nov 25, 2022

CI Reliability 2022-11-25 nodejs/reliability#439

Open

CI Reliability 2022-11-26 nodejs/reliability#440

Open

CI Reliability 2022-11-27 nodejs/reliability#441

Open

This was referenced Nov 28, 2022

CI Reliability 2022-11-28 nodejs/reliability#442

Open

CI Reliability 2022-11-29 nodejs/reliability#443

Open

CI Reliability 2022-11-30 nodejs/reliability#444

Open

github-actions bot mentioned this pull request Dec 1, 2022

CI Reliability 2022-12-01 nodejs/reliability#445

Open

10 tasks

This was referenced Dec 2, 2022

CI Reliability 2022-12-02 nodejs/reliability#446

Open

CI Reliability 2022-12-03 nodejs/reliability#447

Open

CI Reliability 2022-12-04 nodejs/reliability#448

Open

CI Reliability 2022-12-05 nodejs/reliability#449

Open

richardlau approved these changes Dec 7, 2022

View reviewed changes

github-actions bot mentioned this pull request Dec 8, 2022

CI Reliability 2022-12-08 nodejs/reliability#451

Open

8 tasks

Uh oh!

Conversation

MoLow commented Oct 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

targos commented Oct 3, 2022

Uh oh!

MoLow commented Oct 3, 2022

Uh oh!

targos commented Oct 3, 2022

Uh oh!

MoLow commented Oct 3, 2022

Uh oh!

targos commented Oct 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Nov 23, 2022

Uh oh!

MoLow commented Nov 24, 2022

Uh oh!

This comment was marked as resolved.

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Nov 24, 2022

Uh oh!

nodejs-github-bot commented Nov 27, 2022

Uh oh!

nodejs-github-bot commented Nov 30, 2022

Uh oh!

nodejs-github-bot commented Dec 1, 2022

Uh oh!

MoLow commented Dec 1, 2022

Uh oh!

richardlau commented Dec 7, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

MoLow commented Oct 3, 2022 •

edited

Loading

targos commented Oct 3, 2022 •

edited

Loading