-
-
Notifications
You must be signed in to change notification settings - Fork 34.3k
[v25.x] lib: do not provide an empty Proxy from localStorage getter #60776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v25.x] lib: do not provide an empty Proxy from localStorage getter #60776
Conversation
|
The
notable-change
Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section. |
This comment was marked as outdated.
This comment was marked as outdated.
|
Landed in c57a40c |
|
c57a40c was removed from the staging branch, though I cannot reopen this PR (probably because the branch has been deleted). |
|
@Renegade334 it’s not exactly equivalent, it should correctly not mark localStorage as enumerable. |
Addresses the original regression in a way that is more consistent with the user experience in v24.x where no storage-related CLI arguments are passed. Access now warns and returns
undefinedin the case where the requisite path is missing.As things stand, the behaviour will revert to exception-raising in v26.x; any discussion relating to this specifically should go in the associated issue, this PR is just to re-fix the regression for localStorage users in v25.
Refs: #60303